Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spotless): upgrade spinnaker gradle plugin #3838

Merged
merged 1 commit into from
Jul 28, 2020
Merged

chore(spotless): upgrade spinnaker gradle plugin #3838

merged 1 commit into from
Jul 28, 2020

Conversation

plumpy
Copy link
Member

@plumpy plumpy commented Jul 28, 2020

This includes updates to google-java-format and ktlint, so requires some
formatting changes. These were made with a simple ./gradlew spotlessApply.

@plumpy
chore(spotless): upgrade spinnaker gradle plugin
6c2f84e 
This includes updates to google-java-format and ktlint, so requires some
formatting changes. These were made with a simple `./gradlew spotlessApply`.
@plumpy plumpy requested a review from marchello2000 July 28, 2020 15:11
marchello2000
marchello2000 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@marchello2000 marchello2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did I do to deserve reviewing this? :) j/k thanks for doing this, I think this is much more consistent/predictable style than what was there before. ❤️

@marchello2000 marchello2000 added the ready to merge Approved and ready for merge label Jul 28, 2020
@mergify mergify bot merged commit f44c924 into spinnaker:master Jul 28, 2020
@mergify mergify bot added the auto merged Merged automatically by a bot label Jul 28, 2020
@plumpy
Copy link
Member Author

plumpy commented Jul 28, 2020

@marchello2000 Well there were 17 of these reviews, so I just tried to spread them around somewhat randomly :)

@plumpy plumpy deleted the formatting branch July 28, 2020 15:44
@dreynaud
Copy link
Contributor

@plumpy after this change I run into this running ./gradlew clean build:

Step 'google-java-format' found problem in 'orca-clouddriver/src/main/groovy/com/netflix/spinnaker/orca/clouddriver/CloudDriverTaskStatusService.java':
com/google/googlejavaformat/java/JavaFormatterOptions has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0```

@plumpy
Copy link
Member Author

plumpy commented Jul 28, 2020

Oh, can you switch to compiling with Java 11? I didn't necessarily mean to introduce that requirement, but all the CI builds have been using the Java 11 compiler for three months now.

@dreynaud
Copy link
Contributor

yeah that worked. I bet most of us were still on java 8, so the switchening is happening

KathrynLewis pushed a commit to KathrynLewis/orca that referenced this pull request Jan 31, 2021
@plumpy @KathrynLewis
chore(spotless): upgrade spinnaker gradle plugin (spinnaker#3838)
61f6c65 
This includes updates to google-java-format and ktlint, so requires some
formatting changes. These were made with a simple `./gradlew spotlessApply`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchello2000 marchello2000 marchello2000 approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.22
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plumpy @dreynaud @marchello2000 @spinnakerbot