fix(stage): Handle SKIPPED tasks and synthetic stages #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchello2000
approved these changes
Jul 28, 2020
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
* fix(stage): Handle SKIPPED tasks and synthetic stages * fix lint Co-authored-by: Qijia Wang <qijia.wang@grabtaxi.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix spinnaker/spinnaker#5936.
Before this PR,
CompleteStageHandlertreatsSKIPPEDtasks/synthetics as "unhandled condition".As a result,
SKIPPEDtasks and synthetic stages will mark the (parent) stage asTERMINAL.This is not desirable because:
SKIPPEDis benignSKIPPEDstage won't fail a pipeline and the behaviour is inconsistentSKIPPEDhas valid use cases, for example synthetic stages conditional on parent stage outputAfter this PR,
SKIPPEDtask or synthetic stage won't fail (parent) stage.A special case is where all the tasks are skipped. The stage status will be
SUCCEEDEDinstead ofSKIPPED, to differentiate from the case where the stage itself is conditional and skipped.