fix(disable): enforce serverGroup.disabled is true #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's simplify the logic in WaitForClusterDisableTask: 1. first make sure that the server group disabled flag is set 2. then delegate to waitForRequiredInstancesDownTask to check the various healths and the more subtle points like whether interestingHealthProviderNames are set or not Motivation: it was possible to get out of WaitForClusterDisableTask with a server group that had Down instances but `disabled: false`, therefore it would still count as an active server group and would be filtered out by downstream stages like scaleDownServerGroup.
caseyhebebrand
approved these changes
Jul 24, 2020
ajordens
reviewed
Jul 27, 2020
| def targetServerGroup = serverGroup.get() | ||
| if (targetServerGroup.isDisabled() || stage.context.desiredPercentage) { |
There was a problem hiding this comment.
Is there something special here about the partial disables for RRB?
There was a problem hiding this comment.
not sure why there used to be, waitForRequiredInstancesDownTask.hasSucceeded knows how to deal with partial disables
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
Let's simplify the logic in WaitForClusterDisableTask: 1. first make sure that the server group disabled flag is set 2. then delegate to waitForRequiredInstancesDownTask to check the various healths and the more subtle points like whether interestingHealthProviderNames are set or not Motivation: it was possible to get out of WaitForClusterDisableTask with a server group that had Down instances but `disabled: false`, therefore it would still count as an active server group and would be filtered out by downstream stages like scaleDownServerGroup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's simplify the logic in WaitForClusterDisableTask:
Motivation: it was possible to get out of WaitForClusterDisableTask with a server group that had Down instances but
disabled: false, therefore it would still count as an active server group and would be filtered out by downstream stages like scaleDownServerGroup.