fix(preconfigured): Allow PreconfiguredJobStage parameters to map to one-dimensional array property values #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...main/groovy/com/netflix/spinnaker/orca/clouddriver/pipeline/job/PreconfiguredJobStage.groovy
Outdated
Show resolved
Hide resolved
marchello2000
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Thank you, @jaydee864! Apologies this took me a while to review.
All looks good minor comment about the exception.
Co-authored-by: Mark Vulfson <markvu@live.com>
|
@marchello2000 @cfieber @srekapalli Are there any further changes needed from my side on this PR? |
srekapalli
approved these changes
Aug 3, 2020
|
This is a great candidate for backporting @Mergifyio backport release-1.19.x release-1.20.x release-1.21.x edit the fix is for 1.21 so the 1.19 and 1.20 backports will fail 🤣 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 6, 2020
…one-dimensional array property values (#3830) * fix(preconfigured): Update setNestedValue to handle one-dimensional array objects * fix(preconfigured): Handle case where array property is missing from root object * refactor(preconfigured): Use Groovy regex syntax * refactor(preconfigured): Update exception message to be more meaningful Co-authored-by: Mark Vulfson <markvu@live.com> Co-authored-by: Mark Vulfson <markvu@live.com> (cherry picked from commit 3fa29ca)
|
Command
|
kevinawoo
pushed a commit
that referenced
this pull request
Aug 6, 2020
…one-dimensional array property values (bp #3830) (#3846) * fix(preconfigured): Update setNestedValue to handle one-dimensional array objects * fix(preconfigured): Handle case where array property is missing from root object * refactor(preconfigured): Use Groovy regex syntax * refactor(preconfigured): Update exception message to be more meaningful Co-authored-by: Mark Vulfson <markvu@live.com> Co-authored-by: Mark Vulfson <markvu@live.com> (cherry picked from commit 3fa29ca) Co-authored-by: Joe DeStefano <jld864@gmail.com>
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
…one-dimensional array property values (spinnaker#3830) * fix(preconfigured): Update setNestedValue to handle one-dimensional array objects * fix(preconfigured): Handle case where array property is missing from root object * refactor(preconfigured): Use Groovy regex syntax * refactor(preconfigured): Update exception message to be more meaningful Co-authored-by: Mark Vulfson <markvu@live.com> Co-authored-by: Mark Vulfson <markvu@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses spinnaker/spinnaker#5889 by checking for property nodes which end in array notation and extracting them from the parent node as a List, then returning the Object at the desired index.
Notably, this PR does not support 2+ dimensional arrays (eg. "foo[0][1]"). I struggled to come up with a clean and viable solution for handling that scenario, but I'm also not entirely sure it's needed for the object models that Orca is currently working with.