feat(exceptions): add generic exception handler for UserException #737
Conversation
| @@ -134,6 +133,7 @@ private void storeException( | |||
| HttpServletRequest request, HttpServletResponse response, Exception ex) { | |||
| // store exception as an attribute of HttpServletRequest such that it can be referenced by | |||
| // GenericErrorController | |||
| logger.warn("Handled error in generic exception handler", ex); | |||
There was a problem hiding this comment.
added this because otherwise there often no logs of the exception that caused this handler to fire...
|
@marchello2000 @cfieber : This looks to be breaking application creation (and potentially some other workflows that interact with The issue is that In some places (particularly orca) we have logic that ignores a 404 response and handles a missing object as a special case. One example is application creation, where we first check if the application exists (expecting a 404) and create it if it's missing. I'm not sure whether the fix is to: Either way I think we should fix/revert this reasonably quickly as the integration tests are completely broken (and in this case I don't think it's a false positive...I'm unable to create an application in my test spinnaker either). |
|
My vote is to jettison the front50-specific cc: @marchello2000 |
|
Ugh... @ezimanyi, thanks for catching this. |
Follow up from spinnaker/kork#737 where I added a generic 400 response exception handler for UserException. But `front50` needs to return an actual 404 (since callers, e.g. `orca` expect and handle it). Kork already has a generic 404 handler for NotFoundException
|
|
|
made this: spinnaker/front50#922 looking at other services nothing jumps out, (keel uses |
Follow up from spinnaker/kork#737 where I added a generic 400 response exception handler for UserException. But `front50` needs to return an actual 404 (since callers, e.g. `orca` expect and handle it). Kork already has a generic 404 handler for NotFoundException
No description provided.