Add Sigstore on workload attestor for SPIRE #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
904b24d to
5a1bab1
Compare
|
Add sigstore attestor |
There was a problem hiding this comment.
Thank you @willallves for opening this PR!
I'm just starting with the review. I noticed that updates in go.mod / go.sum are not included in the PR. Could you please add them? Also, there are changes that I don't think that are intended to be part of the PR. I pointed them.
I see other PRs that have been opened that depend on this PR. Ideally, PRs that depend on other should be opened after the dependent PRs are merged because they will most likely need to be updated to reflect feedback.
e9f07c9 to
79f82e8
Compare
matheusdefarias
previously approved these changes
Jun 15, 2022
5cb69b0 to
1aeb8cc
Compare
e563103 to
9135823
Compare
MarcosDY
reviewed
Jul 22, 2022
pkg/agent/plugin/workloadattestor/k8s/sigstore/sigstorecache_test.go
Outdated
Show resolved
Hide resolved
pkg/agent/plugin/workloadattestor/k8s/sigstore/sigstorecache_test.go
Outdated
Show resolved
Hide resolved
pkg/agent/plugin/workloadattestor/k8s/sigstore/sigstorecache_test.go
Outdated
Show resolved
Hide resolved
pkg/agent/plugin/workloadattestor/k8s/sigstore/sigstorecache_test.go
Outdated
Show resolved
Hide resolved
788caa8 to
59d008f
Compare
|
@amartinezfayo @MarcosDY @evan2645 @azdagron @rturner3 Requesting review |
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
* tests: fixed defaultCheckOpts error testing on FetchImageSignatures tests Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed redundant type for empty structs Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br>
MarcosDY
reviewed
Dec 20, 2022
| @@ -53,6 +53,31 @@ since [hostprocess](https://kubernetes.io/docs/tasks/configure-pod-container/cre | |||
| | `use_anonymous_authentication` | If true, use anonymous authentication for kubelet communication | | |||
| | `node_name_env` | The environment variable used to obtain the node name. Defaults to `MY_NODE_NAME`. | | |||
| | `node_name` | The name of the node. Overrides the value obtained by the environment variable specified by `node_name_env`. | | |||
| | `experimental` | The experimental options that are subject to change or removal. | | |||
There was a problem hiding this comment.
we have some new requirements about tables on markdown tables, and this PR is reformatting this table
pkg/agent/plugin/workloadattestor/k8s/sigstore/sigstore_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
#200) refactor: removed some empty lines and moved unexported functions and structs to the end of the file Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
* fix: changed optional parameter to pointer Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> * fix: removed unused parameter Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> * fix: changed import order Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> * fix: changed pointer logic Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> * fix: changed pointer logic in moved function Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com>
…ed (#202) Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
lint: reformatted md tables for compliance Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br>
Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
MarcosDY
previously approved these changes
Jan 4, 2023
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
MarcosDY
approved these changes
Jan 5, 2023
amartinezfayo
approved these changes
Jan 5, 2023
stevend-uber
pushed a commit
to stevend-uber/spire
that referenced
this pull request
Oct 16, 2023
* Added Sigstore workload attestor for SPIRE Thanks to: @willallves @rodrigolc @joaoguazzelli @marcusvtms @otaviolcs3 @tjamir @matheusdefarias Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com> Signed-off-by: Matheus Santos <mfcs@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: joaoguazzelli <joao.guazzelli@gmail.com> Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Co-authored-by: Matheus Santos <mfcs@cesar.org.br> Co-authored-by: Matheus de Farias Cavalcanti Santos <matheusdefariascs@gmail.com> Co-authored-by: Rodrigo Lopes <rodrigolpscarvalho@gmail.com> Co-authored-by: Thiago Jamir <tjamir@gmail.com> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com> Co-authored-by: Guazzelli <joao.guazzelli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Description of change
Which issue this PR fixes