Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HCL config to main #146

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Move HCL config to main #146

merged 6 commits into from
Apr 23, 2024

Conversation

faisal-memon
Copy link
Collaborator

Decouples HCL config from the pkg that runs the daemon. This is how the main SPIRE repo is organized.

@faisal-memon faisal-memon requested a review from MarcosDY as a code owner March 14, 2024 02:08
@faisal-memon faisal-memon added this to the 0.8.0 milestone Mar 14, 2024
MarcosDY
MarcosDY reviewed Apr 17, 2024
View reviewed changes
cmd/spiffe-helper/config/config.go Show resolved Hide resolved
cmd/spiffe-helper/config/config_test.go Outdated Show resolved Hide resolved
cmd/spiffe-helper/main.go Outdated Show resolved Hide resolved
MarcosDY
MarcosDY reviewed Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment, and can you resolve DCO, so we can merge?

cmd/spiffe-helper/main.go Outdated Show resolved Hide resolved
@faisal-memon
Move HCL config to main
ef4b135 
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon
Move to config directory
2652420 
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon
move test data
1bdaf71 
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon
Move functionality to config directory
fb9e858 
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon
Add unit test
47ea4aa 
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon
Address pr comments
90ecefb 
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon
Copy link
Collaborator Author

DCO is fixed

@MarcosDY MarcosDY merged commit eb7a200 into main Apr 23, 2024
12 checks passed
@MarcosDY MarcosDY deleted the config-reorg branch April 23, 2024 14:00
@faisal-memon faisal-memon mentioned this pull request Apr 25, 2024
Closed
@faisal-memon faisal-memon mentioned this pull request May 28, 2024
Merged
@faisal-memon faisal-memon mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosDY MarcosDY MarcosDY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@faisal-memon @MarcosDY