Write private key in accordance with Asymmetric Key Packages RFC #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key is marshaled using [MarshalPKCS8PrivateKey](https://pkg.go.dev/crypto/x509#MarshalPKCS8PrivateKey) which suggests the "PRIVATE KEY" PEM block type, and [Asymmetric Key Packages RFC](https://datatracker.ietf.org/doc/html/rfc5958) states: > When .p8 files are PEM encoded they use the .pem file extension. PEM encoding is ... Base64 encoding, see Section 4 of [RFC4648], of the DER-encoded PrivateKeyInfo sandwiched between: > -----BEGIN PRIVATE KEY----- > -----END PRIVATE KEY----- Signed-off-by: Aliaksei Shainiuk <alexey.sheynuk@gmail.com>
faisal-memon
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key is marshaled using MarshalPKCS8PrivateKey which suggests the "PRIVATE KEY" PEM block type, and Asymmetric Key Packages RFC states:
Closes #87