Fix task_history output for sql, add output to table_schema & list_datasets tool #3166
+75
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipleblanc
commented
Oct 21, 2024
phillipleblanc
commented
Oct 21, 2024
phillipleblanc
commented
Oct 21, 2024
ewgenius
approved these changes
Oct 21, 2024
Jeadie
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Fixes the task_history output for SQL queries, add the output for the tools
table_schemaandlist_datasetsand use a fork ofarrow-rsthat implementsDecimal128andDecimal256types to ensure we provide output for SQL queries which return decimal values.Also fixes an issue where if the zipkin endpoint wasn't available, it would prevent the task_history table from being populated due to the opentelemetry exporter timing out.
🔨 Related Issues
arrow-rs PR: apache/arrow-rs#6606
📄 Documentation Requirements
N/A