fix: libraryVersion quote slicing
#1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mejango
approved these changes
Sep 16, 2024
mejango
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of slicing into the
libraryVersionstring we now replace quotes, this makes it so if there are no quotes it doesn't remove/replace anything.Related Issue
#1732
Type of change
Motivation and Context
New versions of foundry no longer have the version double quoted, this PR makes it so it works for both the older versions of foundry as well as the newer versions.
How Has This Been Tested?