Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #4550: All tables and figures without align option are displayed to center #6017

Merged
merged 1 commit into from
Feb 10, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Feb 4, 2019

Feature or Bugfix

  • Feature

Purpose

@tk0miya tk0miya added type:enhancement enhance or introduce a new feature markup labels Feb 4, 2019
@tk0miya tk0miya added this to the 2.0.0 milestone Feb 4, 2019
sphinx/io.py Outdated
@@ -21,7 +21,7 @@
from sphinx.deprecation import RemovedInSphinx30Warning
from sphinx.transforms import (
ApplySourceWorkaround, ExtraTranslatableNodes, CitationReferences,
DefaultSubstitutions, MoveModuleTargets, HandleCodeBlocks, SortIds,
DefaultSubstitutions, MoveModuleTargets, HandleCodeBlocks, SortIds, FigureAliner,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps FigureAligner is better spelling? :)

sphinx/transforms/__init__.py Outdated Show resolved Hide resolved
@tk0miya tk0miya force-pushed the 4550_align_figures_to_center branch 2 times, most recently from 8c4928e to 0ebb8dc Compare February 7, 2019 15:59
@tk0miya tk0miya force-pushed the 4550_align_figures_to_center branch from 0ebb8dc to 2502794 Compare February 7, 2019 16:39
@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #6017 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6017      +/-   ##
==========================================
- Coverage   82.93%   82.91%   -0.03%     
==========================================
  Files         270      272       +2     
  Lines       39074    39114      +40     
  Branches     5847     5851       +4     
==========================================
+ Hits        32406    32430      +24     
- Misses       5321     5334      +13     
- Partials     1347     1350       +3
Impacted Files Coverage Δ
tests/test_build_html.py 97.3% <ø> (ø) ⬆️
sphinx/io.py 67.88% <ø> (ø) ⬆️
tests/test_ext_autosummary.py 98.05% <100%> (ø) ⬆️
sphinx/transforms/__init__.py 88.26% <100%> (+0.37%) ⬆️
sphinx/__init__.py 73.91% <0%> (ø)
sphinx/make_mode.py 0% <0%> (ø)
sphinx/writers/html5.py 82.55% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cca840...2502794. Read the comment docs.

@tk0miya tk0miya merged commit 3a237f7 into sphinx-doc:master Feb 10, 2019
@tk0miya tk0miya deleted the 4550_align_figures_to_center branch February 10, 2019 11:54
@tk0miya
Copy link
Member Author

tk0miya commented Feb 10, 2019

Merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
markup type:enhancement enhance or introduce a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants