Do not apply smart quotes if Sphinx says no, even if Docutils says yes #4360

jfbu · 2017-12-29T17:09:37Z

This closes #4359.

Relates #3967.

jfbu · 2017-12-29T17:39:42Z

sphinx/io.py

@@ -53,6 +53,8 @@ def __init__(self, app, parsers={}, *args, **kwargs):
            parser = parser_class()
            if hasattr(parser, 'set_application'):
                parser.set_application(app)
+            if hasattr(parser, 'set_smartquotes_allowed'):
+                parser.set_smartquotes_allowed(app.env.settings['smart_quotes'])


as far as I understand, this will be called from a BuildEnvironment object read_doc() method, when a reader is being set up, and at that time the app.env.settings['smart_quotes'] always exists with value either True or False due to earlier code executed by the BuildEnvironment instance.

Now, perhaps the accessor method is superfluous here and we should set the Boolean directly rather than having such an instance method added to RSTParser class.

jfbu · 2017-12-29T17:49:35Z

@tk0miya perhaps we can reconsider now the 79df05b which reverted bfd39c1 ? I forgot the reason why bfd39c1 was reverted. With this PR, a Sphinx smart_quotes conf.py setting will be obeyed and override whatever Docutils global config file says. It will also override local docutils.conf so we should modify our docs.

edit1: "override" is not correct; it applies only in case the smart_quotes is activated via docutils.conf, then if Sphinx decides to turn it off, it will work. But it smart_quotes is de-activated (explicitely) via docutils.conf, then no matter what Sphinx config says, it will remain de-activated. In brief, de-activation whether coming from Docutils or Sphinx side always wins.

edit2: I have ressurected bfd39c1 in modified form in 2nd commit of this PR.

jfbu · 2017-12-29T18:47:04Z

I should clarify that initial commit of this PR does only what the title says: if Sphinx setting disallows smart quotes, then they are not applied and Docutils setting is ignored. But if Sphinx setting does allow smart quotes, then they still can be unactivated if Docutils configuration files docutils.conf or ~/.docutils says so.

tk0miya · 2017-12-30T00:47:37Z

sphinx/parsers.py

@@ -58,12 +58,21 @@ def set_application(self, app):
 class RSTParser(docutils.parsers.rst.Parser):
    """A reST parser customized for Sphinx."""

+    smartquotes_allowed = True
+
+    def set_smartquotes_action(self, action):


Let's make RSTParser class a subclass of sphinx.parsers.Parser. After that we can refer config object by self.config.
I think storing status to class variable is not good way. Because it behaves like global variables.

agreed, done (will comment after push)

tk0miya · 2017-12-30T00:54:40Z

doc/config.rst

@@ -353,6 +353,39 @@ General configuration

   .. versionadded:: 1.3

+.. confval:: smart_quotes


I agree the basic concept of this PR. But we would need to be able to disable smart_quotes by several condition.
For example, #4142 tells us to disable it for Japanese document. I saw somebody wants to disable it for arbitrary builder in some issues.
So I think this should not be boolean. (but I don't have good alternative idea...)

I have addressed that by supplementary smartquotes_excludes dict configuration setting at 88a6e24 (fixed typo in doc at 4b3a091)

tk0miya · 2017-12-30T00:59:30Z

perhaps we can reconsider now the 79df05b which reverted bfd39c1 ?

The reason of the revert is only it is not intended commit. It was not my completed work as I commented above. I think simple boolean setting is not good for this case. So we have to consider the way to configure smart_quotes.

It's okay to introduce a configuration for smart_quotes itself to me.

tk0miya · 2017-12-30T01:40:35Z

I'd forggeten to mention about parsers. I think smart quotes is not only for reST files. It is a setting for representation, so it should effect to other formats.
If user want to do that, it is better if configurable.

jfbu · 2017-12-30T09:40:37Z

sphinx/parsers.py

+        # type: (Sphinx) -> None
+        Parser.set_application(self, app)
+        if hasattr(SphinxSmartQuotes, 'smartquotes_action'):
+            SphinxSmartQuotes.smartquotes_action = self.env.settings['smartquotes_action']


I have a problem here which is that afaik SphinxSmartQuotes is a class, not an instance of that class, and in get_transforms below it is the class object which is added to list of transforms. Hence I needed to modify the class attribute here. Don't know if this can have undesired consequences.

Right, class attribute is a kind of global variable. So modifying it is not good way. So it would be better to update it temporarily like following:

from contextlib import contextmanager @contextmanager def sphinx_smartquotes_action(env): try: original = SphinxSmartQuotes.smartquotes_action SphinxSmartQuotes.smart_quotes_action = env.config.smartquotes_action yield finally: SphinxSmartQuotes.smart_quotes_action = original # in env.doc_read() method: with sphinx_smartquotes_action(self): doctree = read_doc(...)

Thanks, will do.

jfbu · 2017-12-30T09:46:03Z

sphinx/environment/__init__.py

@@ -692,6 +691,7 @@ def read_doc(self, docname, app=None):
                break
        else:
            self.settings['smart_quotes'] = False
+        self.settings['smartquotes_action'] = self.config.smartquotes_action


Docutils has no smartquotes_action user config setting yet; but it introduced the docutils.transforms.universal.SmartQuotes class attribute at 0.14, and it is useful for us, because Sphinx users may want to for example not apply smart quotes to ellipsis conversion (from ...). For Docutils < 0.14, there was at some point some bad config which educated backticks also, and we override that in our own sphinx.util.smartypants (this module is used by Sphinx only for Docutils < 0.14).

Is there any reason for setting this into self.settings?

It was in anticipation that Docutils might offer such an option in future to configure the smartquotes_action attribute of its docutils.transforms.universal.SmartQuotes, which we inherit for SphinxSmartQuotes. Also, I did this before RSTParser inherited from Parser hence got access to app. Thinking twice, it might indeed be better not to set this into self.settings, else we will again have problem that a Docutils config file would override the Sphinx user conf.py, if such an option is introduced in future by Docutils.

If docutils does not implement the option yet, it might be too premature action. -1 for adding key.

I have removed it from self.settings, but I do keep it as confval because it is useful for Sphinx users. Is that ok?

jfbu · 2017-12-30T09:53:31Z

I'd forggeten to mention about parsers. I think smart quotes is not only for reST files. It is a setting for representation, so it should effect to other formats.
If user want to do that, it is better if configurable.

My knowledge of how Sphinx interacts with Docutils remains quite limited. At 69cf328 you created a class RSTParser apparently especially for facilitating customization at Sphinx level of Docutils Smart Quotes transform. Do you mean here that this code should actually be in Sphinx Parser class, not RSTParser?

jfbu · 2017-12-30T11:33:53Z

I think simple boolean setting is not good for this case. So we have to consider the way to configure smart_quotes.

@tk0miya I have added confval setting smartquotes_excludes. It has limitations particularly for builders, as multiple builders can share same pickled environment, so user has to explicitely request re-parsing of source files when doing html then text builds for example; or when doing make html text then smart quotes will be applied to text target too, despite setting of smartquotes_excludes. Best I can do for the moment due to shared BuildEnvironment.

I have not addressed the issue about extending PR to other than RSTParser, because my knowledge of Sphinx/Docutils workflow is currently too limited.

jfbu · 2017-12-30T11:54:51Z

doc/config.rst

+   that in case of invocation of ``make`` with multiple builder names, the
+   first one counts.  Also, when using ``sphinx-build`` in succession for
+   different builders, one needs to use ``-E`` option (e.g. in case of an
+   ``html`` build followed by a ``man`` build, or conversely.)


ah sorry, I am not used to sphinx-build but as it creates by default a .doctrees individual to each target, there is no need for -E. The problem arises when using the "make-mode" only. Will fix docs.

jfbu · 2017-12-30T12:28:26Z

sphinx/environment/__init__.py

@@ -677,21 +677,37 @@ def read_doc(self, docname, app=None):
        language = self.config.language or 'en'
        self.settings['language_code'] = language
        if 'smart_quotes' not in self.settings:
-            self.settings['smart_quotes'] = True
+            self.settings['smart_quotes'] = self.config.smart_quotes


now that Sphinx core has a smart_quotes config setting, possibly the logic for

if 'smart_quotes' not in self.settings:

(see #4112) is gone? can an extension override a config setting rather than add it to environment as done at sphinx-contrib/spelling@6209fa8 ?

I think it is not a public interface, but it is needed for workaround. So please keep this as is.

Note: It might be refactored in future. Personally, I feel read_doc is not a part of responsibility of "BuildEnvironment".

ok, I will leave it. I find "BuildEnvironment" complicated...

Absolutely, BuildEnvironment has multiple responsibility. So I'd like to split it into some modules in future.

jfbu · 2017-12-31T10:29:58Z

Currently the sphinx-quickstart created Makefile (whether make-mode enabled or not) configures builds to share doctrees/ across build targets. On the other hand the default behaviour of sphinx-build does not do that. I see the speed gain into sharing the cached files, but the smart quotes issue shows that there is a problem when the Docutils parsing should behave differently depending on builder. It is a bit of thorny issue because indeed it will be disconcerting to user if make html epub latex man re-parses source files (which takes time on big docs) for each target. We can not escape that by implementing "man will always force re-parsing", because then make man html will inhibit smart quotes in html output. However we could set "man" and "text" builders to force re-parsing and store the parsed files in special location. I.e. there would be doctrees/ and doctrees-nosmartquotes/.

Then the builders listed in smartquotes_excludes['builder'] would use doctrees-nosmartquotes and the others doctrees/. This looks a bit ugly for only one problem and not very scalable in (improbable) case some other Docutils implemented transform than Smart Quotes arises in future with similar issues.

tk0miya · 2017-12-31T13:29:21Z

doc/config.rst

+
+   This is a ``dict`` whose default is::
+
+     {'language': ['ja'], 'builder': ['man', 'text']}


I think it is better to rename keys plural form.

I was using singular for easing up re-use of the key as getattr(self.config, key), but I agree it is more self-explanatory to use plurals. In theory any config key is usable here to condition usage of Smart Quotes, but in practice I guess I can just drop the final "s". Or we allow only conditioning on language and builder? Also, I will explain better in docs that the logic is simply "OR".

I can't think of the usecase for any config key (without language). So I feel it's okay to restrict the key to languages and builders.

Also, I will explain better in docs that the logic is simply "OR".

+1

tk0miya · 2017-12-31T13:55:11Z

sphinx/environment/__init__.py

@@ -677,21 +677,37 @@ def read_doc(self, docname, app=None):
        language = self.config.language or 'en'
        self.settings['language_code'] = language
        if 'smart_quotes' not in self.settings:
-            self.settings['smart_quotes'] = True
+            self.settings['smart_quotes'] = self.config.smart_quotes


I think it is not a public interface, but it is needed for workaround. So please keep this as is.

Note: It might be refactored in future. Personally, I feel read_doc is not a part of responsibility of "BuildEnvironment".

tk0miya · 2017-12-31T14:54:11Z

sphinx/environment/__init__.py

+                if valname == 'builder':
+                    # this will work only for checking first build target
+                    if self.app.builder.name in vallist:
+                        self.settings['smart_quotes'] = False


Ideally, smart quotes transform should be invoked after the pickling (write phase) to support each builders.
I know it is a bit big refactoring. so +1 this for stable.

tk0miya · 2017-12-31T15:17:29Z

sphinx/parsers.py

+        # type: (Sphinx) -> None
+        Parser.set_application(self, app)
+        if hasattr(SphinxSmartQuotes, 'smartquotes_action'):
+            SphinxSmartQuotes.smartquotes_action = self.env.settings['smartquotes_action']


Right, class attribute is a kind of global variable. So modifying it is not good way. So it would be better to update it temporarily like following:

from contextlib import contextmanager @contextmanager def sphinx_smartquotes_action(env): try: original = SphinxSmartQuotes.smartquotes_action SphinxSmartQuotes.smart_quotes_action = env.config.smartquotes_action yield finally: SphinxSmartQuotes.smart_quotes_action = original # in env.doc_read() method: with sphinx_smartquotes_action(self): doctree = read_doc(...)

tk0miya · 2017-12-31T15:40:51Z

sphinx/environment/__init__.py

@@ -692,6 +691,7 @@ def read_doc(self, docname, app=None):
                break
        else:
            self.settings['smart_quotes'] = False
+        self.settings['smartquotes_action'] = self.config.smartquotes_action


Is there any reason for setting this into self.settings?

tk0miya · 2017-12-31T16:49:07Z

Do you mean here that this code should actually be in Sphinx Parser class, not RSTParser?

docutils picks up transform modules by get_components() of related components. So I think SphinxStandaloneReader is better.

jfbu · 2018-01-01T15:17:52Z

@tk0miya I have implemented your advices. I checked that SmartQuotes then applies also to Markdown files as added following the docs.

If docutils does not implement the option yet, it might be too premature action. -1 for adding key.

I removed it ;-) (I mean, I do not add it to env.settings but I keep it as a Sphinx option, as it is useful)

jfbu · 2018-01-01T15:32:49Z

sphinx/parsers.py

@@ -55,15 +53,16 @@ def set_application(self, app):
        self.info = app.info


-class RSTParser(docutils.parsers.rst.Parser):
+class RSTParser(docutils.parsers.rst.Parser, Parser):


now inheriting from Parser is not needed, because we don't need access to app. Should I delete that added inheritance ?

jfbu · 2018-01-01T15:33:43Z

sphinx/io.py

+    def __init__(self, app, parsers={}, *args, **kwargs):
+        SphinxBaseReader.__init__(self, app, parsers, *args, **kwargs)
+        if app.env.settings['smart_quotes']:
+            self.transforms.append(SphinxSmartQuotes)


with this, also .md source files (for example) are in the scope of Smart Quotes, which was not the case before.

jfbu · 2018-01-01T15:34:37Z

sphinx/environment/__init__.py

+                        warnings.warn("'%s' (from '%s' in smartquotes_excludes) "
+                                      "isn't a valid configuration variable. "
+                                      "Did you forget an ending 's'?"
+                                      % (valname[:-1], valname))


perhaps the whole else clause could be dropped if we limit to conditioning on language and builder

As I commented above, I can't imagine the use case for this else block.
I don't opposite it, but I'd like to know an example use case before merging.

sorry I overlooked your comment, I will remove that block as I don't see obvious use case either

jfbu · 2018-01-01T15:35:54Z

doc/config.rst

+      O="-E"`` to force re-parsing of source files, as the cached ones are
+      already transformed.  On the other hand the issue does not arise with
+      direct usage of :program:`sphinx-build` as it caches
+      (in its default usage) the parsed source files in per builder locations.


should we document like this our defects ;-) or leave it to user to discover ;-) ?

This is internally and hard to understand behavior. So it should be documented. Let's go with as is.

tk0miya

LGTM with nits

tk0miya · 2018-01-01T15:38:27Z

sphinx/environment/__init__.py

+def sphinx_smartquotes_action(env):
+    try:
+        original = SphinxSmartQuotes.smartquotes_action
+        setattr(SphinxSmartQuotes, 'smartquotes_action',


Is there any reason to using setattr? An assignment is much simpler to me.

I used an assignment but it did not have expected effect in my testing. Was it because SphinxSmartQuotes is imported separately in io.py?

hmm... works perfectly well with an assignment. Don't know what went wrong (but I am doing various things at the same time, bad habit...). Ok, will push fix.

tk0miya · 2018-01-01T15:43:49Z

sphinx/io.py

+    def __init__(self, app, parsers={}, *args, **kwargs):
+        SphinxBaseReader.__init__(self, app, parsers, *args, **kwargs)
+        if app.env.settings['smart_quotes']:
+            self.transforms.append(SphinxSmartQuotes)


Please override get_transforms() and add SphinxSmartQuotes conditionally. because self.transforms is a class variable. So SphinxSmartQuotes will be added on each instantiation.

def __init__(...): ... self.smart_quotes = app.env.settings['smart_quotes'] def get_transforms(self): transforms = SphinxBaseReder.get_transforms() if self.smart_quotes: transforms.append(SphinxSmartQuotes) return transforms

sorry for my basic mistake. Indeed build time considerably increased due to it. I will fix.

tk0miya · 2018-01-01T15:45:29Z

sphinx/parsers.py

@@ -55,15 +53,16 @@ def set_application(self, app):
        self.info = app.info


-class RSTParser(docutils.parsers.rst.Parser):
+class RSTParser(docutils.parsers.rst.Parser, Parser):


Parser super class is no longer needed.

jfbu · 2018-01-01T16:24:19Z

sphinx/environment/__init__.py

@@ -96,10 +96,9 @@
 def sphinx_smartquotes_action(env):
    try:


the try is needed because Docutils SmartQuotes does not have the smartquotes_action attribute at Docutils < 0.14.

jfbu · 2018-01-01T16:25:28Z

sphinx/parsers.py

@@ -53,7 +53,7 @@ def set_application(self, app):
        self.info = app.info


-class RSTParser(docutils.parsers.rst.Parser, Parser):
+class RSTParser(docutils.parsers.rst.Parser):


The Parser inheritance was added in an earlier commit of this PR (#4360), but is now not needed

tk0miya · 2018-01-01T18:15:18Z

sphinx/environment/__init__.py

+        original = SphinxSmartQuotes.smartquotes_action
+        SphinxSmartQuotes.smartquotes_action = env.config.smartquotes_action
+        yield
+        SphinxSmartQuotes.smartquotes_action = original


This is not executed when the error has happened at yield block. Usually, it does not effect to the processing because sphinx-build crashes on the error. But the behavior might be changed in future. So it should be write back correctly using final clause.
How about this implementation?

if not hasattr(SphinxSmartQuotes, 'smartquotes_action'): # less than docutils-0.14 yield else: # docutils-0.14 or above try: original = SphinxSmartQuotes.smartquotes_action SphinxSmartQuotes.smartquotes_action = env.config.smartquotes_action finally: SphinxSmartQuotes.smartquotes_action = original

+1, I guess I add a yield in the try ;-)

tk0miya · 2018-01-01T18:15:44Z

sphinx/environment/__init__.py

@@ -91,6 +92,17 @@
 }  # type: Dict[unicode, Union[bool, Callable]]


+@contextmanager
+def sphinx_smartquotes_action(env):


Please add type annotation: # type: (BuildEnvironment) -> Generator.

jfbu · 2018-01-02T12:06:47Z

closing and reopening to trigger again testing

tk0miya

Great work!

tk0miya · 2018-01-03T01:08:28Z

CHANGES

@@ -17,6 +17,10 @@ Features added
 * ``VerbatimHighlightColor`` is a new
  :ref:`LaTeX 'sphinxsetup' <latexsphinxsetup>` key (refs: #4285)
 * Easier customizability of LaTeX macros involved in rendering of code-blocks
+* Add :confval:`smart_quotes` to disable smart quotes through ``conf.py``


I noticed smartquotes_disables does not mentioned here.

Anyway, these settings for smart quotes are named smart_quotes or smartquotes. I feel they should have same prefix. What do you think?

smartquotes_excludes is mentioned at next line ...

I agree about using same prefix smartquotes for all. Docutils has a smart_quotes or smart-quotes option and this why I originally used smart_quotes. But Docutils has the smartquotes_action class attribute hence I also followed. But I feel smartquotes prefix for all conf.py variables is much better indeed.

oh, sorry > smartquotes_excludes

tk0miya

LGTM!

tk0miya · 2018-01-04T01:03:11Z

CHANGES

@@ -17,6 +17,10 @@ Features added
 * ``VerbatimHighlightColor`` is a new
  :ref:`LaTeX 'sphinxsetup' <latexsphinxsetup>` key (refs: #4285)
 * Easier customizability of LaTeX macros involved in rendering of code-blocks
+* Add :confval:`smart_quotes` to disable smart quotes through ``conf.py``


oh, sorry > smartquotes_excludes

tk0miya · 2018-01-05T13:44:15Z

ping @jfbu

Do you still have any remaining work for this PR? If none, could you merge this please?
Then I will release 1.6.6 in this weekend.

If you have tasks, I can wait it. So please let me know.

Thanks,

jfbu · 2018-01-05T13:48:28Z

@tk0miya Thanks for very thorough reviewing and expert Python guidance! To make for cleaner commit history and due to the fact the PR was importantly refactored mid-way I will rebase and squash commits and then I will merge. ;-)

(I am preserving for some time original history there)

closes sphinx-doc#4142 closes sphinx-doc#4357 closes sphinx-doc#4359 refs: sphinx-doc#3967 Adds ``smartquotes``, ``smartquotes_action``, ``smartquotes_excludes`` configuration variables. - if ``smartquotes`` is set to False, then Smart Quotes transform is not applied even if a Docutils configuration file activates it, - the current default of ``smartquotes_excludes`` deactivates Smart Quotes for Japanese language, and also for the ``man`` and ``text`` builders. However, currently ``make text html`` deactivates Smart Quotes for ``html`` too, and ``make html text`` activates them for ``text`` too, because the picked environment is shared and already transformed. - now Smart Quotes get applied also when source documents are in Markdown or other formats.

jfbu · 2018-01-05T14:23:23Z

I will merge once testing completes 🎉

jfbu · 2018-01-05T14:56:39Z

Merging because Travis fails due to connect timeout errors.

tk0miya · 2018-01-06T11:11:47Z

🎉 Great work!

jfbu added the type:bug label Dec 29, 2017

jfbu added this to the 1.6.6 milestone Dec 29, 2017

jfbu mentioned this pull request Dec 29, 2017

Smart-quotes should not operate on the doctree #3967

Open

jfbu commented Dec 29, 2017

View reviewed changes

tk0miya reviewed Dec 30, 2017

View reviewed changes

tk0miya mentioned this pull request Dec 30, 2017

1.6.6 release plan #4361

Closed

jfbu commented Dec 30, 2017

View reviewed changes

jfbu mentioned this pull request Dec 31, 2017

make man replacing ellipsis string (...) with single-character #4357

Closed

tk0miya reviewed Dec 31, 2017

View reviewed changes

jfbu commented Jan 1, 2018

View reviewed changes

tk0miya requested changes Jan 1, 2018

View reviewed changes

jfbu commented Jan 1, 2018

View reviewed changes

jfbu force-pushed the 4359_tame_docutils_conf branch from 5ca4cee to 85d1689 Compare January 1, 2018 16:34

tk0miya requested changes Jan 1, 2018

View reviewed changes

jfbu closed this Jan 2, 2018

jfbu reopened this Jan 2, 2018

tk0miya approved these changes Jan 3, 2018

View reviewed changes

tk0miya reviewed Jan 3, 2018

View reviewed changes

tk0miya mentioned this pull request Jan 3, 2018

Move smart_quotes feature to post_transform #4371

Open

tk0miya approved these changes Jan 4, 2018

View reviewed changes

jfbu force-pushed the 4359_tame_docutils_conf branch from 48a6379 to b90f2b0 Compare January 5, 2018 14:10

jfbu added a commit to jfbu/sphinx that referenced this pull request Jan 5, 2018

Update CHANGES for PR sphinx-doc#4360

b90f2b0

Update CHANGES for PR sphinx-doc#4360

0d824df

jfbu force-pushed the 4359_tame_docutils_conf branch from b90f2b0 to 0d824df Compare January 5, 2018 14:16

jfbu merged commit 7950176 into sphinx-doc:stable Jan 5, 2018

jfbu mentioned this pull request Jan 6, 2018

Sphinx fails to distinguish open and close quotation marks #4142

Closed

jfbu deleted the 4359_tame_docutils_conf branch January 12, 2018 19:46

github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2021

		@@ -353,6 +353,39 @@ General configuration

		.. versionadded:: 1.3

		.. confval:: smart_quotes


		This is a ``dict`` whose default is::

		{'language': ['ja'], 'builder': ['man', 'text']}

Do not apply smart quotes if Sphinx says no, even if Docutils says yes #4360

Do not apply smart quotes if Sphinx says no, even if Docutils says yes #4360

Conversation

jfbu commented Dec 29, 2017

Choose a reason for hiding this comment

jfbu commented Dec 29, 2017 • edited Loading

jfbu commented Dec 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tk0miya commented Dec 30, 2017

tk0miya commented Dec 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfbu commented Dec 30, 2017

jfbu commented Dec 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfbu commented Dec 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tk0miya commented Dec 31, 2017

jfbu commented Jan 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tk0miya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfbu commented Jan 2, 2018

tk0miya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tk0miya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tk0miya commented Jan 5, 2018

jfbu commented Jan 5, 2018 • edited Loading

jfbu commented Jan 5, 2018

jfbu commented Jan 5, 2018

tk0miya commented Jan 6, 2018

jfbu commented Dec 29, 2017 •

edited

Loading

jfbu commented Jan 1, 2018 •

edited

Loading

jfbu commented Jan 5, 2018 •

edited

Loading