-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression fixup: respect anchor-check configuration setting #11544
Merged
AA-Turner
merged 8 commits into
sphinx-doc:7.1.x
from
jayaddison:issue-11542/anchor-linkcheck-regression
Aug 2, 2023
Merged
Regression fixup: respect anchor-check configuration setting #11544
AA-Turner
merged 8 commits into
sphinx-doc:7.1.x
from
jayaddison:issue-11542/anchor-linkcheck-regression
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
reviewed
Aug 1, 2023
AA-Turner
reviewed
Aug 1, 2023
francoisfreitag
approved these changes
Aug 1, 2023
Looking good. Maybe also add a mention to the release note? |
AA-Turner
pushed a commit
to AA-Turner/sphinx
that referenced
this pull request
Aug 2, 2023
AA-Turner
force-pushed
the
issue-11542/anchor-linkcheck-regression
branch
from
August 2, 2023 01:02
7a34e63
to
8aa643a
Compare
…n anchor checking is not enabled
… linkcheck builder tests
AA-Turner
force-pushed
the
issue-11542/anchor-linkcheck-regression
branch
from
August 2, 2023 01:05
8aa643a
to
b7e54ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
linkcheck_anchors
setting was not being respected.Detail
linkcheck
builder code has been attempting to read content from these responses.Relates