1.6.1 incorrectly warns about dedent with literalinclude

[dhermes]

Problem

Our build fails when running sphinx-build with the -W flag. An example would be

  .. literalinclude:: logging_snippets.py
     :start-after: [START client_create_default]
     :end-before: [END client_create_default]
     :dedent: 4

and viewing the actually included source, one can see that 4 space dedent is correct. (FWIW I tried 1-space dedent and it also failed.)

Procedure to reproduce the problem

sphinx-build -W -b html -d docs/_build/doctrees docs/ docs/_build/html/

Error logs / results

Warning, treated as error:
/var/code/gcp/docs/logging-usage.rst.rst:25:Over dedent has detected

• Public link: build

Expected results

The build should succeed.

Reproducible project / your project

• Project: https://github.com/GoogleCloudPlatform/google-cloud-python (just run nox -s docs at the project root, though you may have to install pip install nox-automation)

Environment info

• OS: Ubuntu (not sure which version our docker image uses)
• Python version: 3.6
• Sphinx version: 1.6.1

[tk0miya]

Thank you for reporting and sorry for inconvenience.
Fixed at dabd356.

[dhermes]

Thanks @tk0miya. Would you like me to install from HEAD to verify or to wait until a release?

[tk0miya]

I confirmed it works well at local. But it would be nice if you also confirm this.
Anyway, we will release next bug-fixed version soon. So it's okay to wait it.

[dhermes]

Just confirmed via:

pip install git+https://github.com/sphinx-doc/sphinx/

See build.