[MISC] Fix build in py39 #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f46514 to
ee4cfb6
Compare
pradyunsg
reviewed
Apr 27, 2024
|
Huh, it seems I can't accept the change I've suggested to move ahead with merging this. @nikoskoukis-slamcore Have you unticked the "maintainers can push" checkbox on your branch? |
|
It's a checkbox like this in the sidebar: |
greut
reviewed
May 3, 2024
| self.paths = [os.path.realpath(path, strict=True) for path in paths] | ||
| self.paths = [os.path.realpath(path) for path in paths] | ||
|
|
||
| # Santiy check the paths |
There was a problem hiding this comment.
Suggested change
| # Santiy check the paths | |
| # Sanity check the paths |
|
This PR was opened from a fork within an organisation, which doesn't allow pushing commits -- this is an issue with GitHub. See #157. A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use
realpath(... strict=True)which isn't available in py3.9. Instead explicitly check whether the given paths exist.Fixes #155 .