feat(slo): group by slo id (elastic#210469)

sphilipse · Feb 11, 2025 · 9545d6b · 9545d6b
1 parent d36df89
commit 9545d6b
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 1 deletion.
diff --git a/x-pack/platform/packages/shared/kbn-slo-schema/src/rest_specs/routes/find_group.ts b/x-pack/platform/packages/shared/kbn-slo-schema/src/rest_specs/routes/find_group.ts
@@ -14,6 +14,7 @@ const groupBySchema = t.union([
   t.literal('slo.indicator.type'),
   t.literal('slo.instanceId'),
   t.literal('_index'),
+  t.literal('slo.id'),
 ]);
 
 const findSLOGroupsParamsSchema = t.partial({

diff --git a/...solutions/observability/plugins/slo/public/pages/slos/components/common/quick_filters.tsx b/...solutions/observability/plugins/slo/public/pages/slos/components/common/quick_filters.tsx
@@ -59,6 +59,9 @@ export function QuickFilters({
           align-items: flex-start;
           min-height: initial;
         }
+        .controlPanel {
+          height: initial;
+        }
         .controlGroup {
           min-height: initial;
         }

diff --git a/...servability/plugins/slo/public/pages/slos/components/grouped_slos/hooks/use_group_name.ts b/...servability/plugins/slo/public/pages/slos/components/grouped_slos/hooks/use_group_name.ts
@@ -18,6 +18,7 @@ export function useGroupName(groupBy: GroupByField, group: string, summary?: Gro
     case 'ungrouped':
     case 'slo.tags':
     case 'status':
+    case 'slo.id':
       return groupName;
     case 'slo.instanceId':
       if (groupName === ALL_VALUE || !summary?.worst?.slo?.groupings) {

diff --git a/...ck/solutions/observability/plugins/slo/public/pages/slos/components/slo_list_group_by.tsx b/...ck/solutions/observability/plugins/slo/public/pages/slos/components/slo_list_group_by.tsx
@@ -80,6 +80,16 @@ export function SloGroupBy({ onStateChange, state, loading }: Props) {
         handleChangeGroupBy('slo.indicator.type');
       },
     },
+    {
+      label: i18n.translate('xpack.slo.list.groupBy.sloId', {
+        defaultMessage: 'SLO definition id',
+      }),
+      checked: groupBy === 'slo.id',
+      value: 'slo.id',
+      onClick: () => {
+        handleChangeGroupBy('slo.id');
+      },
+    },
     {
       label: i18n.translate('xpack.slo.list.groupBy.sloInstanceId', {
         defaultMessage: 'SLO instance id',

diff --git a/x-pack/solutions/observability/plugins/slo/public/pages/slos/types.ts b/x-pack/solutions/observability/plugins/slo/public/pages/slos/types.ts
@@ -12,7 +12,8 @@ export type GroupByField =
   | 'status'
   | 'slo.indicator.type'
   | 'slo.instanceId'
-  | '_index';
+  | '_index'
+  | 'slo.id';
 export type SortDirection = 'asc' | 'desc';
 export type SortField =
   | 'sli_value'