-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitignore to track cobra subdirectory #936
Conversation
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
Hi @rhcarvalho! I just sumitted a similar PR (#946). The difference is that you ignore an explicit location |
Hi @umarcor. I had considered initially a similar approach as what you wrote in your PR. However, on second thought and seeing how that line was introduced, I realized that ignoring It is not possible to have a "cobra" executable in the top-level (because of the directory with the same name), and there is no good reason to generically ignore other files or directories named "cobra" in other paths. |
Thanks for clarifying! I'm closing #946 in favour of this. |
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
closed by #976 |
@jharshman, #976 seems to work around this issue, but not fix it. Using the makefiles will not produce |
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra' executable generated by 'go build' during development. However, 'cobra' is a directory containing the command line tool, and such a generic entry in .gitignore ignores too much. Instead of the generic 'cobra' entry, ignore only a specific '/cobra/cobra' path.
The 'cobra' entry on .gitignore was meant to ignore a potential 'cobra'
executable generated by 'go build' during development. However, 'cobra'
is a directory containing the command line tool, and such a generic
entry in .gitignore ignores too much.
Instead of the generic 'cobra' entry, ignore only a specific
'/cobra/cobra' path.