cobra init no longer works as documented
#888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cobra init github.com/spf13/newApp` results in `Error: required flag(s) "pkg-name" not set`
This alternative works but it's not intuitive to me as a noob user that it's correct.
In order to test what it does, I tried `cobra init a --pkg-name=b` but then `main.go` attempts to (incorrectly) `import "b/cmd"`
I think (!?) I'd expect what you original had: `cobra init github.com/spf13/newApp` creating a directory under `{GOPATH}/src/github.com/spf13/newApp` with `github.com/spf13/newApp` as the package name.
|
|
|
@DazWilkin #817 You should be able to use the generator successfully by entering the directory in which you want to init a project, and running In sum, the documentation for the generator should probably be updated. |
jharshman
requested changes
Jun 21, 2019
|
Ref #878. |
Closed
Merged
|
covered by #904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cobra init github.com/spf13/newAppresults inError: required flag(s) "pkg-name" not setThis alternative works but it's not intuitive to me as a noob user that it's correct.
In order to test what it does, I tried
cobra init a --pkg-name=bbut thenmain.goattempts to (incorrectly)import "b/cmd"I think (!?) I'd expect what you original had:
cobra init github.com/spf13/newAppcreating a directory under{GOPATH}/src/github.com/spf13/newAppwithgithub.com/spf13/newAppas the package name.