Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing license headers #1809

Merged
merged 3 commits into from
Sep 16, 2022
Merged

add missing license headers #1809

merged 3 commits into from
Sep 16, 2022

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Sep 14, 2022

Close #1699.

@github-actions github-actions bot added area/docs-generation Generation of docs via Cobra area/github For changes to Github specific things not shipped in the library size/XL Denotes a PR that exceeds 200 lines. Caution! labels Sep 14, 2022
@github-actions
Copy link

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@marckhouzam
Copy link
Collaborator

Thanks @umarcor for taking the time. Is there a reason some of the doc/ files don't follow the new header?

$ head -1 $(\grep -L "The Cobra Authors" $(find . -name '*.go'))
==> ./doc/yaml_docs.go <==
// Copyright 2016 French Ben. All rights reserved.

==> ./doc/md_docs.go <==
//Copyright 2015 Red Hat Inc. All rights reserved.

==> ./doc/util.go <==
// Copyright 2015 Red Hat Inc. All rights reserved.

==> ./doc/rest_docs.go <==
//Copyright 2015 Red Hat Inc. All rights reserved.

==> ./doc/man_docs.go <==
// Copyright 2015 Red Hat Inc. All rights reserved.

@github-actions
Copy link

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@umarcor
Copy link
Contributor Author

umarcor commented Sep 16, 2022

@marckhouzam, google/addlicense "avoids adding a license header to any file that already has one".

I now updated the files in the doc subdir.

@marckhouzam marckhouzam added admin For general admin tasks to be done usualy by maintainers kind/cleanup General cleanup of code, issues, etc. lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready github_actions Pull requests that update GitHub Actions code and removed area/docs-generation Generation of docs via Cobra area/github For changes to Github specific things not shipped in the library labels Sep 16, 2022
@marckhouzam marckhouzam added this to the 1.6.0 milestone Sep 16, 2022
marckhouzam
marckhouzam approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @umarcor, this is great.

I would have been cool if the google/addlicense tool figured out what the actual dates where based on commit history, but it is not that smart.

@marckhouzam marckhouzam merged commit 6d978a9 into spf13:main Sep 16, 2022
@umarcor umarcor mentioned this pull request Sep 16, 2022
Closed
@umarcor umarcor deleted the lic-headers branch September 16, 2022 13:39
@jpmcb
Copy link
Collaborator

jpmcb commented Sep 16, 2022

Thanks for this! Very nice!!

jimschubert added a commit to jimschubert/cobra that referenced this pull request Oct 3, 2022
@jimschubert
Merge branch 'main' into doc-slash-commands
b5bc3e3 
* main: (39 commits)
  Add '--version' flag to Help output (spf13#1707)
  Expose ValidateRequiredFlags and ValidateFlagGroups (spf13#1760)
  Document option to hide the default completion cmd (spf13#1779)
  ci: add workflow_dispatch (spf13#1387)
  add missing license headers (spf13#1809)
  ci: use action/setup-go's cache (spf13#1783)
  Adjustments to documentation (spf13#1656)
  Rename Powershell completion tests (spf13#1803)
  Support for case-insensitive command names (spf13#1802)
  Deprecate ExactValidArgs() and test combinations of args validators (spf13#1643)
  Use correct stale action `exempt-` yaml keys (spf13#1800)
  With go 1.18, we must use go install for a binary (spf13#1726)
  Clarify SetContext documentation (spf13#1748)
  ci: test on Golang 1.19 (spf13#1782)
  fix: show flags that shadow parent persistent flag in child help (spf13#1776)
  Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 (spf13#1766)
  fix(bash-v2): activeHelp length check syntax (spf13#1762)
  fix: correct command path in see_also for YAML doc (spf13#1771)
  build(deps): bump github.com/inconshreveable/mousetrap (spf13#1774)
  docs: add zitadel to the list (spf13#1772)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marckhouzam marckhouzam marckhouzam approved these changes

Assignees
No one assigned
Labels
admin For general admin tasks to be done usualy by maintainers github_actions Pull requests that update GitHub Actions code kind/cleanup General cleanup of code, issues, etc. lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready size/XL Denotes a PR that exceeds 200 lines. Caution!
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Review inconsistent go file license headers
3 participants
@umarcor @marckhouzam @jpmcb