Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deletefile_test intermittently failing on main #217

Closed
isaac-io opened this issue Nov 7, 2022 · 0 comments · Fixed by #218
Closed

deletefile_test intermittently failing on main #217

isaac-io opened this issue Nov 7, 2022 · 0 comments · Fixed by #218
Assignees
@isaac-io
Labels
bug Something isn't working tests
Milestone
v2.2.0

Comments

@isaac-io
Copy link
Contributor

isaac-io commented Nov 7, 2022

The following test in deletefile_test sometimes fail on main (reported on Slack by @udi-speedb):

[ RUN      ] DeleteFileTest.BackgroundPurgeCFDropTest
db/deletefile_test.cc:124: Failure
Expected equality of these values:
  required_sst
    Which is: 0
  sst_cnt
    Which is: 1
Google Test trace:
db/deletefile_test.cc:380: avoid_unnecessary_blocking_io = true
terminate called after throwing an instance of 'testing::internal::GoogleTestFailureException'
  what():  db/deletefile_test.cc:124: Failure
Expected equality of these values:
  required_sst
    Which is: 0
  sst_cnt
    Which is: 1

This is a continuation of the issue raised in #197, and is caused by the changes introduced in #194. My fix in #197 didn't fully fix the issue for all of the affected tests, apparently.

To Reproduce

Run the test in a loop until it fails. Overloading the machine with activity seems to help the failure manifest quicker:

$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done

Expected behavior

The tests pass successfully.

Additional context

N/A
@isaac-io isaac-io added bug Something isn't working tests labels Nov 7, 2022
@isaac-io isaac-io added this to the v2.2.0 milestone Nov 7, 2022
@isaac-io isaac-io self-assigned this Nov 7, 2022
isaac-io added a commit that referenced this issue Nov 7, 2022
@isaac-io
deletefile_test: fix breakage caused by the compaction threads change (…
2638397 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
@isaac-io isaac-io linked a pull request Nov 7, 2022 that will close this issue
deletefile_test: fix breakage caused by the compaction threads change #218
Merged
isaac-io added a commit that referenced this issue Nov 8, 2022
@isaac-io
deletefile_test: fix breakage caused by the compaction threads change (…
44510c3 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
Yuval-Ariel pushed a commit that referenced this issue Nov 15, 2022
@isaac-io @Yuval-Ariel
deletefile_test: fix breakage caused by the compaction threads change (…
8d61c9e 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
deletefile_test: fix breakage caused by the compaction threads change (…
e3ee1ce 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
@isaac-io @Yuval-Ariel
deletefile_test: fix breakage caused by the compaction threads change (…
9138814 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
@isaac-io @Yuval-Ariel
deletefile_test: fix breakage caused by the compaction threads change (…
c8d00a3 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
@isaac-io @Yuval-Ariel
deletefile_test: fix breakage caused by the compaction threads change (…
ab702c5 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
@isaac-io @udi-speedb
deletefile_test: fix breakage caused by the compaction threads change (…
8ea2ab2 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
udi-speedb pushed a commit that referenced this issue Nov 15, 2023
@isaac-io @udi-speedb
deletefile_test: fix breakage caused by the compaction threads change (…
7366ae8 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
udi-speedb pushed a commit that referenced this issue Dec 3, 2023
@isaac-io @udi-speedb
deletefile_test: fix breakage caused by the compaction threads change (…
8ae95b9 
…#217)

In #194 the default value for background compaction threads was changed
to 8 (from 1). This caused some tests to fail and fixes were implemented
as part of #197. Alas, it seems that the fixes weren't complete, as under
stress a test still fail.

Make it so the test is truly fixed now. This can be verified by running
them in a loop with the machine overloaded:

```
$ while ./deletefile_test --gtest_filter=DeleteFileTest.BackgroundPurgeCFDropTest; do sleep 1; done
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaac-io isaac-io

Labels
bug Something isn't working tests
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

deletefile_test: fix breakage caused by the compaction threads change speedb-io/speedb
1 participant
@isaac-io