Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fe2): resolve PortalTarget SSR attribute inheritance warning #3804

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(fe2): resolve PortalTarget SSR attribute inheritance warning #3804

merged 1 commit into from
Jan 13, 2025

Conversation

andrewwallacespeckle
Copy link
Contributor

I noticed a hydration warning in console, so wrapped PortalTarget with ClientOnly to prevent SSR-related issues.

image

fabis94
fabis94 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@fabis94 fabis94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoping we can get rid of the portal altogether at some point

@andrewwallacespeckle andrewwallacespeckle merged commit 01ccc0d into main Jan 13, 2025
26 of 28 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/fix-portal-target-ssr-warning branch January 13, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabis94 fabis94 fabis94 approved these changes

@Mikehrn Mikehrn Awaiting requested review from Mikehrn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewwallacespeckle @fabis94