Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): remove direct form value mutation in SSO login #3779

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix(auth): remove direct form value mutation in SSO login #3779

merged 1 commit into from
Jan 8, 2025

Conversation

andrewwallacespeckle
Copy link
Contributor

Remove direct form value mutation through v-model in SSO login component.
The component already handles form state through internal vee-validate integration.

fabis94
fabis94 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@fabis94 fabis94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, the CI failure can be ignored too

@andrewwallacespeckle andrewwallacespeckle merged commit 2d40640 into main Jan 8, 2025
26 of 28 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/sso-login-form-values-mutation branch January 8, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabis94 fabis94 fabis94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewwallacespeckle @fabis94