Add document expiration feature. Fixes #1652. #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabatkins
requested changes
Apr 23, 2020
|
Add some tests and the one fix, and this is R+ from me |
Closed
|
Well, I guess we'll want to do the "starts closed, uses js to open after expiration" behavior for the not-yet-expired case |
Added tests and accept never & boolish false in a33f871. Haven't done the JS bit yet. The current patch defaults to open for the expired case, and defaults to closed for the "has an expiration date set, but it's in the future" case. |
|
Okay, I added the JS and did some other minor fixup, including making sure the tests weren't dependent on the date they were generated, since that means they'll fail tomorrow. ^_^ Also added docs for the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first cut at an expiration feature like we're talking about in #1652.
One annoyance is this adds a dependency on
isodatein order to parse ISO 8601 durations.