Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report an error when an UNKNOWN_TAG is found #55

Closed
yash-nisar opened this issue Mar 21, 2018 · 2 comments
Closed

Report an error when an UNKNOWN_TAG is found #55

yash-nisar opened this issue Mar 21, 2018 · 2 comments

Comments

@yash-nisar
Copy link
Contributor

Steps to reproduce:

  • When I modify any tag, e.g SPDXVersion: SPDX-1.2 to SPDXVersio: SPDX-1.2, the tool should report an error like Found unknown tag : SPDXVersio at line: 2 but instead it continues to parse.

The tokenizing works fine, the problem is with the parsing method.
@yash-nisar
Copy link
Contributor Author

yash-nisar commented Mar 22, 2018 •
edited
Loading

A better way to reproduce the bug would be:

  • On adding an unwanted line like:
SPDXVersion: SPDX-1.2
SPDXVersio: SPDX-1.2

the parsing should emit an error, but it continues to parse without raising any error.

yash-nisar added a commit to yash-nisar/tools-python that referenced this issue Apr 27, 2018
@yash-nisar
Report an error when UNKNOWN_TAG is found spdx#55
2e9c450 
The cause of the error was the method ​`p_unknown_tag`
in `parsers/tagvalue.py`. Due to the incorrect context-free grammar specification defined in the method, the line after the `unknown_tag` was not taken into consideration. The
context-free grammar specification was rectified and tests
were corresponding tests were added.

Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
yash-nisar added a commit to yash-nisar/tools-python that referenced this issue Apr 27, 2018
@yash-nisar
Report an error when UNKNOWN_TAG is found spdx#55
68554db 
The cause of the error was the method ​`p_unknown_tag`
in `parsers/tagvalue.py`. Due to the incorrect context-free grammar specification defined in the method, the line after the `unknown_tag` was not taken into consideration. The
context-free grammar specification was rectified and tests
were corresponding tests were added.

Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
yash-nisar added a commit to yash-nisar/tools-python that referenced this issue Apr 27, 2018
@yash-nisar
Report an error when UNKNOWN_TAG is found spdx#55
584c14c 
The cause of the error was the method ​`p_unknown_tag`
in `parsers/tagvalue.py`. Due to the incorrect context-free grammar specification defined in the method, the line after the `unknown_tag` was not taken into consideration. The
context-free grammar specification was rectified and tests
were corresponding tests were added.

Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
yash-nisar added a commit to yash-nisar/tools-python that referenced this issue Apr 27, 2018
@yash-nisar
Report an error when UNKNOWN_TAG is found spdx#55
8959d35 
The cause of the error was the method ​`p_unknown_tag`
in `parsers/tagvalue.py`. Due to the incorrect context-free grammar specification defined in the method, the line after the `unknown_tag` was not taken into consideration. The
context-free grammar specification was rectified and tests
were corresponding tests were added.

Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
yash-nisar added a commit to yash-nisar/tools-python that referenced this issue Apr 27, 2018
@yash-nisar
Report an error when UNKNOWN_TAG is found spdx#55
b35f7d6 
The cause of the error was the method ​`p_unknown_tag`
in `parsers/tagvalue.py`. Due to the incorrect context-free
grammar specification defined in the method, the line after
the `unknown_tag` was not taken into consideration. The
context-free grammar specification was rectified and tests
were corresponding tests were added.

Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
yash-nisar added a commit to yash-nisar/tools-python that referenced this issue Apr 28, 2018
@yash-nisar
Report an error when UNKNOWN_TAG is found spdx#55
0f32bc7 
The cause of the error was the method ​`p_unknown_tag`
in `parsers/tagvalue.py`. Due to the incorrect context-free
grammar specification defined in the method, the line after
the `unknown_tag` was not taken into consideration. The
context-free grammar specification was rectified and tests
were corresponding tests were added.

Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
yash-nisar added a commit to yash-nisar/tools-python that referenced this issue May 7, 2018
@yash-nisar
Report an error when UNKNOWN_TAG is found spdx#55
3700acc 
The cause of the error was the method ​`p_unknown_tag`
in `parsers/tagvalue.py`. Due to the incorrect context-free
grammar specification defined in the method, the line after
the `unknown_tag` was not taken into consideration. The
context-free grammar specification was rectified and tests
were corresponding tests were added.

Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
yash-nisar added a commit to yash-nisar/tools-python that referenced this issue Aug 6, 2018
@yash-nisar
Report an error when UNKNOWN_TAG is found spdx#55
944125c 
The cause of the error was the method ​`p_unknown_tag`
in `parsers/tagvalue.py`. Due to the incorrect context-free
grammar specification defined in the method, the line after
the `unknown_tag` was not taken into consideration. The
context-free grammar specification was rectified and tests
were corresponding tests were added.

Signed-off-by: Yash Nisar <yash.nisar@somaiya.edu>
pombredanne added a commit that referenced this issue Aug 6, 2018
@pombredanne
Merge pull request #62 from yash-nisar/unknown_tag_bug
cc44de9 
Report an error when `UNKNOWN_TAG` is found #55

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@meretp
Copy link
Collaborator

meretp commented Oct 17, 2022

This issue is solved and can be closed. @nicoweidner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yash-nisar @meretp @nicoweidner