Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null before access to creation info / license info #175

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Handle null before access to creation info / license info #175

merged 4 commits into from
Dec 17, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Dec 16, 2024

  • Check if a return value from getCreationInfo() or getLicenseDeclared() is null before access.
  • Suppress one null warning for a command line that null is already checked

bact added 2 commits December 16, 2024 07:40
@bact
Check if getCreationInfo is null before access
8ed2c6b 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Fix small typo
cea9542 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
goneall
goneall requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple requested changes, otherwise checking for nulls is a good improvement

src/main/java/org/spdx/tools/Verify.java Outdated Show resolved Hide resolved
src/main/java/org/spdx/tools/Verify.java Outdated Show resolved Hide resolved
@bact @goneall
Update src/main/java/org/spdx/tools/Verify.java
ffa00ad 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Co-Authored-By: Gary O'Neall <gary@sourceauditor.com>
@bact @goneall
Update src/main/java/org/spdx/tools/Verify.java
ee88fc7 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>

Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
@bact bact requested a review from goneall December 17, 2024 04:48
goneall
goneall approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@goneall goneall merged commit e190384 into spdx:master Dec 17, 2024
1 check passed
@bact bact deleted the handle-null branch December 17, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bact @goneall