Fixes replacement of dict keys #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larly, the internal method _replace_dict_keys skips replacing keys with the same name to avoid erroneously removing the entry completely.
acalotoiu
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the internal method
SDFG._replace_dict_keysis called with the sameoldandnewkeys, then the method erroneously removes the entry for the specific key completely. Such a case occurs when callingSDFG.replace_dictwith a dictionary that contains identity replacement matches.This PR addresses the issue by:
SDFG._replace_dict_keysand skipping ifold == new. A warning is also thrown for debugging purposes.repldictandsymreplinSDFG.replace_dict.