modernize package

.github/workflows/run-tests.yml

@@ -9,20 +9,14 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-latest, windows-latest]
-        php: [8.1, 8.0, 7.4]
+        php: [8.5, 8.4, 8.3]
         dependency-version: [prefer-lowest, prefer-stable]
 
     name: P${{ matrix.php }} - ${{ matrix.dependency-version }} - ${{ matrix.os }}
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v1
-
-      - name: Cache dependencies
-        uses: actions/cache@v1
-        with:
-          path: ~/.composer/cache/files
-          key: php-${{ matrix.php }}-composer-${{ hashFiles('composer.json') }}
+        uses: actions/checkout@v2
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2

.phpunit.cache/test-results

@@ -0,0 +1 @@
+{"version":"pest_3.7.1","defects":[],"times":{"P\\Tests\\SunTest::__pest_evaluable_it_can_determine_if_the_sun_is_up_now":0.006}}

composer.json

@@ -16,13 +16,13 @@
         }
     ],
     "require": {
-        "php": "^8.0|^7.4",
-        "nesbot/carbon": "^2.32"
+        "php": "^8.3",
+        "nesbot/carbon": "^2.32|^3.0"
     },
     "require-dev": {
-        "pestphp/pest": "^1.0",
-        "spatie/test-time": "^1.2",
-        "symfony/var-dumper": "^4.3"
+        "pestphp/pest": "^3.0",
+        "spatie/test-time": "^1.2|^2.0",
+        "symfony/var-dumper": "^4.3|^5.0"
     },
     "autoload": {
         "psr-4": {

phpunit.xml.dist

@@ -1,28 +1,16 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit bootstrap="vendor/autoload.php"
-         backupGlobals="false"
-         backupStaticAttributes="false"
-         colors="true"
-         verbose="true"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
-         processIsolation="false"
-         stopOnFailure="false">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" backupGlobals="false" bootstrap="vendor/autoload.php" colors="true" processIsolation="false" stopOnFailure="false" executionOrder="random" failOnWarning="true" failOnRisky="true" failOnEmptyTestSuite="true" beStrictAboutOutputDuringTests="true" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
     <testsuites>
         <testsuite name="Spatie Test Suite">
             <directory>tests</directory>
         </testsuite>
     </testsuites>
-    <filter>
-        <whitelist>
-            <directory suffix=".php">src/</directory>
-        </whitelist>
-    </filter>
     <logging>
-        <log type="junit" target="build/report.junit.xml"/>
-        <log type="coverage-html" target="build/coverage"/>
-        <log type="coverage-text" target="build/coverage.txt"/>
-        <log type="coverage-clover" target="build/logs/clover.xml"/>
+        <junit outputFile="build/report.junit.xml"/>
     </logging>
+    <source>
+        <include>
+            <directory suffix=".php">./src</directory>
+        </include>
+    </source>
 </phpunit>

src/Sun.php

@@ -17,7 +17,7 @@ public function __construct(float $lat, float $lng)
         $this->lng = $lng;
     }
 
-    public function sunIsUp(Carbon $onDay = null): bool
+    public function sunIsUp(?Carbon $onDay = null): bool
     {
         $onDay = $onDay ?? Carbon::now();
 
@@ -27,7 +27,7 @@ public function sunIsUp(Carbon $onDay = null): bool
         return $onDay->between($sunrise, $sunset);
     }
 
-    public function sunrise(Carbon $onDay = null): Carbon
+    public function sunrise(?Carbon $onDay = null): Carbon
     {
         $onDay = $onDay ?? Carbon::now();
 
@@ -40,7 +40,7 @@ public function sunrise(Carbon $onDay = null): Carbon
         return Carbon::createFromTimestamp($sunriseTimestamp);
     }
 
-    public function zenith(Carbon $onDay = null): Carbon
+    public function zenith(?Carbon $onDay = null): Carbon
     {
         $onDay = $onDay ?? Carbon::now();
 
@@ -53,7 +53,7 @@ public function zenith(Carbon $onDay = null): Carbon
         return Carbon::createFromTimestamp($sunTimestamp);
     }
 
-    public function sunset(Carbon $onDay = null): Carbon
+    public function sunset(?Carbon $onDay = null): Carbon
     {
         $onDay = $onDay ?? Carbon::now();