Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added createFromArray method on SettingsFactory #708

Merged
merged 3 commits into from
Jun 10, 2022
+15 −1
Merged

Added createFromArray method on SettingsFactory #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
657e956
Added createFromArray method on SettingsFactory
doekenorg Jun 10, 2022
3521d53
Update SettingsTest.php
freekmurze Jun 10, 2022
726968a
Update CHANGELOG.md
freekmurze Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Settings/SettingsFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,16 @@ class SettingsFactory
{
public static $cache = [];

public static function createFromArray(array $settings = []): Settings
{
return new Settings($settings);
}

public static function createFromConfigFile(string $configDirectory = null): Settings
{
$settingValues = (new static())->getSettingsFromConfigFile($configDirectory);

$settings = new Settings($settingValues);
$settings = static::createFromArray($settingValues);

if (count($settingValues)) {
$settings->markAsLoadedUsingSettingsFile();
Expand Down
9 changes: 9 additions & 0 deletions tests/SettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ public function it_can_find_the_settings_file_more_than_once()
$this->assertEquals('http://otherhost', $settings2->host);
}

/** @test */
public function it_can_create_settings_from_an_array()
{
$settings = SettingsFactory::createFromArray(['enabled' => false, 'port' => 1234]);

self::assertFalse($settings->enabled);
self::assertSame(1234, $settings->port);
}

protected function skipOnGitHubActions(): void
{
if (getenv('CI')) {
Expand Down