Version 1.9 #81
Merged
Version 1.9 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix next methods
Implement #43 adding createFromOverlappingRanges method
sebastiandedeyne
approved these changes
Dec 7, 2018
|
This looks good! One small thing, we generally prefer to use issues instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sebastiandedeyne @freekmurze this is the commit I would tag as 1.9.0:
4aa091c
See in this PR the global change from 1.8.1.
If you're OK with it, I will create the release, then merge the version-1.9 branch into master and rebase PRs for the v2 onto master.
I will wait for possible feedback on 1.9 and will try to find imagine possible future features that would imply a major change before starting merging stuffs for the v2. But I think the current milestone could be enough: https://github.com/spatie/opening-hours/milestone/1
Fix #43
Fix #73