Two static functions with the same name

[ThibaudDauce]

If two static functions have the same name (in two different classes), the once cache is shared between the two resulting in wrong response during the second call (we can invert the two calls, the second one is always the wrong one).

I've just added a failing test. I read a little bit the code but didn't find the correct way to fix the bug…

In the once function, the $object variable is different for the two classes but the $hash is the same.

[dhrrgn]

The issue is because the hash only uses the function name as a prefix. This is fine for non-static methods, because the object is unique. However, the "object" is a string with static method, so it uses the Cache instance as the object key in the WeakMap (see here). So, all the cache for all static methods is under the same object key, hence the conflict.

The fix would be to include the class name in the hash prefix for static methods (could probably just always include it really).

[freekmurze]

@ThibaudDauce could you add that fix to this PR?

[ThibaudDauce]

@freekmurze Fixed in a9728f8

[freekmurze]

Thanks!

[lloricode]

thanks I notice this issue, I just forgot to report,
and because of this, i will remove temporary fix on my code, since already fix by this

thanks @ThibaudDauce, @spatie