Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fix and tests update #173

Merged
merged 30 commits into from
Dec 11, 2024
Merged

Workflow fix and tests update #173

merged 30 commits into from
Dec 11, 2024

Conversation

aon4o
Copy link
Contributor

@aon4o aon4o commented Jul 22, 2024

  • Fixed failing linter GitHub action.
  • Changed PHP testing framework (PHPUnit to Pest)

@aon4o aon4o changed the title Workflow fix and code modernization Workflow fix and tests update Jul 22, 2024
@aon4o aon4o marked this pull request as draft July 22, 2024 09:24
@freekmurze
Copy link
Member

Thanks for your work on this. Let me know when this is ready for review.

@aon4o
Copy link
Contributor Author

aon4o commented Jul 22, 2024

This code update is ready for review on its own. Right now I am working on an additional branch for namespace separation of translations (#168). Should I first finish the feature I'm working on and add it to this PR or open another one after I'm done? Thanks for the fast response on the PR!

@freekmurze freekmurze marked this pull request as ready for review July 22, 2024 09:52
src/LanguageLine.php Outdated Show resolved Hide resolved
src/TranslationLoaderManager.php Outdated Show resolved Hide resolved
src/TranslationServiceProvider.php Outdated Show resolved Hide resolved
tests/Feature/JsonTransTest.php Outdated Show resolved Hide resolved
tests/Feature/TransTest.php Outdated Show resolved Hide resolved
tests/Pest.php Outdated Show resolved Hide resolved
@aon4o
Copy link
Contributor Author

aon4o commented Jul 22, 2024

Hey, I think I have addressed all of the requested changes in the commits from the past 4 hours.

@aon4o aon4o requested a review from freekmurze July 23, 2024 06:40
@aon4o
Copy link
Contributor Author

aon4o commented Aug 13, 2024

Hi, I hope you're doing well. I don't want to bother you, but I wanted to follow up on the pull request. I have addressed all the changes you requested and would appreciate it if you could take a look when you have the time.

Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a small nitpick.

Are there any breaking changes here?

tests/Feature/TranslationLoaders/DbTest.php Outdated Show resolved Hide resolved
@aon4o
Copy link
Contributor Author

aon4o commented Aug 26, 2024

Looks good, a small nitpick.

Are there any breaking changes here?

No, there are none. The sole purpose of this PR is to modernize the codebase so I could easily implement the Namespaces Feature from the 174 PR.

@aon4o aon4o requested a review from freekmurze August 26, 2024 10:46
@aon4o
Copy link
Contributor Author

aon4o commented Oct 9, 2024

Is there anything else I can do here? If not could I ask again for a review of the changes when you have the time?

@aon4o
Copy link
Contributor Author

aon4o commented Oct 29, 2024

Requesting a review?

@freekmurze
Copy link
Member

There are some conflicts. Could you rebase?

@aon4o
Copy link
Contributor Author

aon4o commented Dec 9, 2024

Fixed the conflict. The tests still pass.

@freekmurze freekmurze merged commit de25698 into spatie:main Dec 11, 2024
9 checks passed
@freekmurze
Copy link
Member

Thank you very much! Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants