-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow fix and tests update #173
Conversation
This reverts commit a3d8682.
Thanks for your work on this. Let me know when this is ready for review. |
Hey, I think I have addressed all of the requested changes in the commits from the past 4 hours. |
Hi, I hope you're doing well. I don't want to bother you, but I wanted to follow up on the pull request. I have addressed all the changes you requested and would appreciate it if you could take a look when you have the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a small nitpick.
Are there any breaking changes here?
No, there are none. The sole purpose of this PR is to modernize the codebase so I could easily implement the Namespaces Feature from the 174 PR. |
Is there anything else I can do here? If not could I ask again for a review of the changes when you have the time? |
Requesting a review? |
There are some conflicts. Could you rebase? |
Fixed the conflict. The tests still pass. |
Thank you very much! Very nice! |
PHPUnit
toPest
)