Improve unserializable response handling #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Jan 30, 2018
|
|
||
| use Exception; | ||
|
|
||
| class CouldntUnserialize extends Exception |
There was a problem hiding this comment.
Rename this to CouldNotUnserialize
freekmurze
reviewed
Jan 30, 2018
tests/ResponseSerializerTest.php
Outdated
| @@ -46,4 +47,12 @@ public function it_can_serialize_and_unserialize_a_response() | |||
|
|
|||
| $this->assertEquals('testValue', $unserializedResponse->headers->get('testHeader')); | |||
| } | |||
|
|
|||
| /** @test */ | |||
| public function it_throws_when_something_something_else_than_a_response_is_unserialized() | |||
There was a problem hiding this comment.
Rename to it_throws_an_exception_when_something_else_than_a_response_is_unserialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of fixes #102
I'd rather treat a case like this as an uncached response, but since
ResponseCache::getCachedResponseForhasResponseas a strict return type, we can't modify the behaviour without a breaking change.I propose we provide a clear exception until we work on the next major version.