Blade component to include feed links #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, could you also add a test for this? |
You mean to verify that the links are inserted in the DOM if the component is used? Sure, I'll add that :) |
|
@freekmurze I added a route that renders the blade component (with a little helper method because I think it's not nice to add a blade file to the repo) and a test that creates a snapshot of the result, just like with the other route where the file is |
|
The tests seem to be failing. Could you take a look at that? |
|
@freekmurze In some environments there was a trailing space. I don't know where that came from, but it works if you |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #147 😄