Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feed type #110

Merged
merged 3 commits into from
Oct 7, 2019
Merged

RSS feed type #110

merged 3 commits into from
Oct 7, 2019

Conversation

Gummibeer
Copy link
Contributor

fixes #108

contains: #109

@freekmurze
Copy link
Member

This one is breaking, right? (due to the feed view being renamed)

@Gummibeer
Copy link
Contributor Author

Gummibeer commented Oct 7, 2019

No, I've kept the feed view which now only includes the atom view. This way it non BC and in the next major release the feed view could get removed.
https://github.com/spatie/laravel-feed/pull/110/files#diff-435f6c9b3b6888ec5700b9075f606994R1

@Gummibeer
Copy link
Contributor Author

During next major release it could also be an idea to remove the feed type from config or make it an array to allow to render the same feed in multiple types. The route should get a suffix .rss, .atom or .json for the new JSON feed type.

@freekmurze freekmurze merged commit d2399d7 into spatie:master Oct 7, 2019
@freekmurze
Copy link
Member

Thanks! I think we can create a new major version when PHP 7.4 arrives. For this (and other package) the plan is to create PHP 7.4 only new major version where we can use typed properties, short closures and all the sweetness that PHP 7.4 brings to the table.

@Gummibeer Gummibeer deleted the ft-rss-feed-type branch October 7, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mix of RSS and Atom
2 participants