Merge pull request #495 from okaufmann/implicit-nullables

Fix Remaining Nullable Parameter Definitions
spatie · Dec 20, 2024 · f6ed36e · f6ed36e
2 parents 67e822d + 236133d
commit f6ed36e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/docs/advanced-usage/using-your-own-event-serializer.md b/docs/advanced-usage/using-your-own-event-serializer.md
@@ -34,7 +34,7 @@ the currency.
 ```
 class UpgradeSerializer extends JsonEventSerializer
 {
-    public function deserialize(string $eventClass, string $json, string $metadata = null): ShouldBeStored
+    public function deserialize(string $eventClass, string $json, ?string $metadata = null): ShouldBeStored
     {
         $event = parent::deserialize($eventClass, $json, $metadata);
 

diff --git a/src/EventSerializers/EventSerializer.php b/src/EventSerializers/EventSerializer.php
@@ -12,6 +12,6 @@ public function deserialize(
         string $eventClass,
         string $json,
         int $version,
-        string $metadata = null
+        ?string $metadata = null
     ): ShouldBeStored;
 }
diff --git a/src/EventSerializers/JsonEventSerializer.php b/src/EventSerializers/JsonEventSerializer.php
@@ -37,7 +37,7 @@ public function deserialize(
         string $eventClass,
         string $json,
         int $version,
-        string $metadata = null
+        ?string $metadata = null
     ): ShouldBeStored {
         return $this->serializer->deserialize($json, $eventClass, 'json');
     }