Validation rules won't work

[robert-stanciu]

Hi, community,

I am using this package validation rule inside a private package that has been generated from spatie/package-skeleton-laravel.

this is the Data class:

use Spatie\LaravelData\Attributes\Validation\Rule;
use Spatie\LaravelData\Data;

class Individual extends Data
{
    public function __construct(
        #[Rule(['required', 'alpha', 'max:2'])]
        public ?string $firstName,
        public string $lastName,
        public string $socialNumber,
        public string $address,
        public string $phone,
        public string $email,
    ) {
    }
}

and this is how I instantiate it:

$individual = Individual::from([
        'firstName' => 'Long name that should fail',
        'lastName' => '',
        'socialNumber' => '',
        'address' => '',
        'phone' => '',
        'email' => '',
    ]);

The way I test the code is by running composer test (Using Pest).

There is no exception/validation done whatsoever. Is there something I am doing wrong?

[rubenvanassche]

Use validateAndCreate since from will only validate when a request has been passed to it.

[rubenvanassche]

We have our own use cases, you have yours. This package is mainly created for our own usage and we open it to everyone to use. Don’t like some of the design decisions we made? No problem! Fork it and adapt it to your particular needs or preferences!

[raveren]

It's not about need or preference, it's what makes sense. Especially with the sub-par documentation, one would expect it to be more self-explanatory.

[raimidev]

If you want the DTO to always run validation, prob the best approach would be to create a BaseDTO in your app that extends from LaravelData and then you can just basically reuse the pipeline that Spatie has with the difference of instead of using the class-string for the ValidatePropertiesDataPipe you just instantiate that pipe and pass true as an argument in the constructor.

public static function pipeline(): DataPipeline
    {
        return DataPipeline::create()
            ->into(static::class)
            ->through(AuthorizedDataPipe::class)
            ->through(MapPropertiesDataPipe::class)
            ->through(FillRouteParameterPropertiesDataPipe::class)
            //Custom pipe to fill from bound model
            ->through(FillPropertiesFromBoundModelPipe::class)
            ->through(TrimTrailingWhitespacesFromValues::class)

           // Right here :)
            ->through(new ValidatePropertiesDataPipe(true))

            ->through(DefaultValuesDataPipe::class)
            ->through(CastPropertiesDataPipe::class);
    }

Our team is fine with always validating the Data since we are working in a payroll system. Hope this helps.
We have also added some custom pipes to it, so some of them might look weird.

[raveren]

It's not a very sustainable approach as you are replicating the internals of the 3rd party library in your code and when the lib changes you will have a high cost of keeping your approach up to date, or more likely, will get tied to a particular old version of this lib in the long run.

[rubenvanassche]

We'll actually the pipeline is considered something a user can do with what they want, so you're not changing internals. Could be a valid option actually.

[slnw]

needs to be fixed in my opinion.

[rubenvanassche]

See the comment from @raimirOCMI above, v4 will make it possible to always validate when using from. But the default behavior will still be disabled.