Add unit tests for DenseVector #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! You need to run |
|
Sorry for that. Now it should be fixed. |
|
Seems |
3ae726d to
62c056d
Compare
|
Thanks for your work on this @aadeg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some code to tests the DenseVector trait.
I used tarpaulin to evaluate the coverage improvement of the dense_vector.rs file: from 35% to 64%.
The tests are pretty simple. If you agree, I'd like to write some more unit tests to get confident with the library code and after that contributing on the algorithms.
I've a C++ dev background, and I've recently started learning Rust, so feel free to highlight any mistakes a did.