Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant calculations for single set pairwise distances #25

Merged
merged 3 commits into from
Jul 30, 2022
Merged

remove redundant calculations for single set pairwise distances #25

merged 3 commits into from
Jul 30, 2022

Conversation

sgbaird
Copy link
Member

@sgbaird sgbaird commented Jul 30, 2022

closes #22

@sgbaird sgbaird linked an issue Jul 30, 2022 that may be closed by this pull request
Avoid redundant calculations for within set pairwise distance matrix #22
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2766264276

  • -3 of 22 (86.36%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 27.15%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/matbench_genmetrics/core.py 19 22 86.36%
Totals Coverage Status
Change from base Build 2766203509: 1.4%
Covered Lines: 134
Relevant Lines: 441
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2766264276

  • 19 of 22 (86.36%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 27.15%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/matbench_genmetrics/core.py 19 22 86.36%
Totals Coverage Status
Change from base Build 2766203509: 1.4%
Covered Lines: 134
Relevant Lines: 441
💛 - Coveralls

@sgbaird sgbaird merged commit bdb3a85 into main Jul 30, 2022
@sgbaird sgbaird deleted the 22-redundant-calc branch July 30, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid redundant calculations for within set pairwise distance matrix
2 participants
@sgbaird @coveralls