Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not always set classification to false #63

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

kjappelbaum
Copy link

hi @sgbaird 👋🏽

Thanks for packaging this up. I think this fix here is needed (perhaps one should also add a simple test that overfits to check that it does what it is supposed to do).

Cheers,
Kevin

@sgbaird
Copy link
Member

sgbaird commented Feb 9, 2023

Oh wow, great catch! Yeah, that definitely looks like the right fix. I haven't dealt too much with classification and CrabNet, and adding a unit test seems to be in order here. I'll go ahead and merge the request for now.

@sgbaird sgbaird merged commit 5600ed0 into sparks-baird:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants