System profiler privacy and transparency #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expose the system profile array publicly - Fix the type of the returned value
- Added SPUDelegate method to allow filtering of system profile array - Expose SUSystemProfiler key constants for cleaner use of the delegate method
kornelski
reviewed
Nov 29, 2020
kornelski
reviewed
Nov 29, 2020
|
Thank you |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some fixes and enhancements to system profiling. Specifically it adds 2 things:
SPUUpdater.systemProfileArrayproperty. This allows developers to access this information to display to users-[SPUUpdaterDelegate allowedSystemProfileKeysForUpdater:]). This helps developers improve privacy by choosing which profile items to collect and send with update requests. This filtering happens before any additional feed parameters are added.It also fixes 2 issues with the system profile code:
NSArray<NSString *, NSString *>(some values are NSNumbers)This is partly related to #1616 and has been implemented on the 2.x branch
This image provides an example of what these changes enable https://coppiceapp.com/images/blog/designing_for_privacy/privacy-sheet.png