Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-aria globals to vite config for UMD build #73

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

JBurkinshaw
Copy link
Collaborator

Description

Add globals related to react-aria to vite.config.ts' rollup output options.

Fixes the following warnings which were in the output of npm run build:

No name was provided for external module "react-aria-components" in "output.globals" – guessing "reactAriaComponents".
No name was provided for external module "react-aria" in "output.globals" – guessing "reactAria".
No name was provided for external module "@internationalized/date" in "output.globals" – guessing "date".

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Instructions

Run npm run build. The above warnings will not be displayed.

@JBurkinshaw JBurkinshaw requested a review from atweedie February 10, 2025 20:09
@JBurkinshaw JBurkinshaw merged commit 18fe66b into main Feb 11, 2025
1 check passed
@JBurkinshaw JBurkinshaw deleted the react-aria-globals-for-umd-build branch February 11, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants