Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bias saving and loading. #105

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

ThreadOfFate
Copy link
Contributor

No description provided.

@PaulZC
Copy link
Contributor

PaulZC commented Nov 14, 2022

Hi @ThreadOfFate ,

Thanks for the contribution! I'm merging this into the release_candidate branch for testing.

I've had a quick look at how you're using our code in the SlimeVR-Tracker-ESP. Nice work.

Questions:

  • Is saving and restoring the biases working OK for you?
  • Do you have a 'feel' for how critical the save intervals are? (I see you're saving after 2min + 3min + 5min + 10min)

Best wishes,
Paul

@PaulZC PaulZC changed the base branch from main to release_candidate November 14, 2022 09:50
@PaulZC PaulZC merged commit 650a2ea into sparkfun:release_candidate Nov 14, 2022
@PaulZC
Copy link
Contributor

PaulZC commented Nov 14, 2022

Hi @ThreadOfFate ,

I've included the new methods in v1.2.10. I corrected the capitalization in the method names, so you will need to adjust your SlimeVR-Tracker code accordingly. Please see the release notes for details:

https://github.com/sparkfun/SparkFun_ICM-20948_ArduinoLibrary/releases/tag/v1.2.10

Thanks again for the contribution,
Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants