Implement hasReset() to track Reset Complete response. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @mattbradford83 , |
|
Hey @PaulZC how's this one going? |
|
Hi @mattbradford83 , Thanks for the reminder! ;-) Can you please re-target your PR at the release-candidate branch so I can merge and test it? Contributing guidelines are here. Many thanks, |
|
Well, there you go. I learned something new today! ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great library with lots of great features for debugging this troublesome chip.
One thing that appears to be missing is the tracking of the "Reset Complete" Executable response packet (BNO08X documentation, P24, fig 1-27). This is needed to determine if the chip resets unexpectedly, so that reports can be re-set.
It also pairs really well with the resetReason() function. I've added some code to document this working, along with an example of how to use it to show a software reset.