Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TI Launchpad #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TransientResponse
Copy link

These additions add suport for TI Tiva C-Series Launchpad boards, in particular the EK-TM4C1294 Connected Launchpad. Support for others can be added very easily by simply adding another defined(...) clause in the header's #if statements.

Also, the result() functions now take one argument: a user-supplied array of byte (that is, unsigned char or uint8_t) allocated to 32 bytes. Before, these functions returned a raw pointer to the SHA function's internal state, which could allow the user to accidentally (or intentionally) corrupt said state. Now the library copies bytes from the SHA's state to the user-supplied array.

Still has compilation issues which require breaking compatibility with
other hardware.
Just need to figure out which memory section to put the big arrays.
"flash" section not supported correctly, using ".text" instead.
Also, result functions no longer return raw pointers to internal state.
@spaniakos
Copy link
Owner

Thanks for the support .
I won't be able to check it until monday.
Will check and merge it then.
On Dec 20, 2014 3:24 PM, "TransientResponse" notifications@github.com
wrote:

These additions add suport for TI Tiva C-Series Launchpad boards, in
particular the EK-TM4C1294 Connected Launchpad. Support for others can be
added very easily by simply adding another defined(...) clause in the
header's #if statements.

Also, the result() functions now take one argument: a user-supplied array
of byte (that is, unsigned char or uint8_t) allocated to 32 bytes.
Before, these functions returned a raw pointer to the SHA function's
internal state, which could allow the user to accidentally (or
intentionally) corrupt said state. Now the library copies bytes from the

SHA's state to the user-supplied array.

You can merge this Pull Request by running

git pull https://github.com/TransientResponse/Cryptosuite master

Or view, comment on, or merge it at:

#1
Commit Summary

  • Adapted to work on TI Launchpad TM4C1294
  • Now (should) work with Arduino and RPi also
  • Fixed compatibility with Arduino, RPi, Galileo
  • Fixed memory location for PROGMEM
  • Ported changes to SHA1

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1.

@TransientResponse
Copy link
Author

OK.

Sent from my Windows Phone


From: Georgios Spanosmailto:notifications@github.com
Sent: ‎12/‎20/‎2014 9:46 AM
To: spaniakos/Cryptosuitemailto:Cryptosuite@noreply.github.com
Cc: TransientResponsemailto:TransientResponse@outlook.com
Subject: Re: [Cryptosuite] Added support for TI Launchpad (#1)

Thanks for the support .
I won't be able to check it until monday.
Will check and merge it then.
On Dec 20, 2014 3:24 PM, "TransientResponse" notifications@github.com
wrote:

These additions add suport for TI Tiva C-Series Launchpad boards, in
particular the EK-TM4C1294 Connected Launchpad. Support for others can be
added very easily by simply adding another defined(...) clause in the
header's #if statements.

Also, the result() functions now take one argument: a user-supplied array
of byte (that is, unsigned char or uint8_t) allocated to 32 bytes.
Before, these functions returned a raw pointer to the SHA function's
internal state, which could allow the user to accidentally (or
intentionally) corrupt said state. Now the library copies bytes from the

SHA's state to the user-supplied array.

You can merge this Pull Request by running

git pull https://github.com/TransientResponse/Cryptosuite master

Or view, comment on, or merge it at:

#1
Commit Summary

  • Adapted to work on TI Launchpad TM4C1294
  • Now (should) work with Arduino and RPi also
  • Fixed compatibility with Arduino, RPi, Galileo
  • Fixed memory location for PROGMEM
  • Ported changes to SHA1

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1.


Reply to this email directly or view it on GitHub:
#1 (comment)

@spaniakos
Copy link
Owner

hello.

i have cchecked your code and it seems good.
but i cannot accept the pull request as i have some changes in my file structure, and some code separation and/or cleanup.
i can implement the changes but hand if you want, or i can wait if you like to re-fork or commitmy changes and re-add the missing code from your.
If this is too much to ask, u can always just implement the canges by hand and add you to the Readme file as a contritbutor.

Thanks
spaniakos

@TransientResponse
Copy link
Author

Commit your changes and I'll re-add mine afterwards. It'll also give me time to implement a few other changes that I had in mind.

Sent from my Windows Phone


From: Georgios Spanosmailto:notifications@github.com
Sent: ‎12/‎23/‎2014 8:46 AM
To: spaniakos/Cryptosuitemailto:Cryptosuite@noreply.github.com
Cc: TransientResponsemailto:TransientResponse@outlook.com
Subject: Re: [Cryptosuite] Added support for TI Launchpad (#1)

hello.

i have cchecked your code and it seems good.
but i cannot accept the pull request as i have some changes in my file structure, and some code separation and/or cleanup.
i can implement the changes but hand if you want, or i can wait if you like to re-fork or commitmy changes and re-add the missing code from your.
If this is too much to ask, u can always just implement the canges by hand and add you to the Readme file as a contritbutor.

Thanks
spaniakos


Reply to this email directly or view it on GitHub:
#1 (comment)

@spaniakos
Copy link
Owner

my changes are now commited, had some file separation as you can see.
i am revising all my libraries today as i moved my equipment from my lab to a vacation place, thow i still have to implement code :D. by the end of tomorrow i would have implemented any change i might do from the revision.

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants