Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build system + tox #297

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Fix build system + tox #297

merged 3 commits into from
Jan 11, 2021

Conversation

jhunkeler
Copy link
Contributor

@jhunkeler jhunkeler commented Jan 6, 2021 •
edited by pllim
Loading

Description

UPDATE: Attempted a fix for #295 but did not work out, still managed to remove dependence on extension-helpers and simplified the C-extension code.

@jhunkeler jhunkeler force-pushed the fix-build-system branch 2 times, most recently from d4fe0ff to 8672000 Compare January 6, 2021 21:54
@codecov
Copy link

codecov bot commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #297 (6228183) into master (193e91d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          13       13           
  Lines        1967     1967           
=======================================
  Hits         1865     1865           
  Misses        102      102
Impacted Files Coverage Δ
synphot/binning.py 93.03% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 193e91d...6228183. Read the comment docs.

@jhunkeler jhunkeler force-pushed the fix-build-system branch 3 times, most recently from 496e3a7 to e3cc529 Compare January 7, 2021 19:00
pllim
pllim reviewed Jan 7, 2021
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also delete docstring.py as it is no longer needed.

MANIFEST.in Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
jhunkeler and others added 2 commits January 11, 2021 15:59
@jhunkeler @pllim
Fix build system
e23ec4b 
Use static docstring

Update pyproject.toml

Update MANIFEST.in

Add headers to manifest

Remove unused docstring generator

Force --no-deps builds to work

Remove C source .gitignore files

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
@pllim
Undo catching numpy import error in setup
848760a
@pllim pllim added this to the 1.1.0 milestone Jan 11, 2021
@pllim
Minor clean-ups
6228183 
[skip codeql]
pllim
pllim approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Joe!

@pllim pllim merged commit b52e211 into spacetelescope:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

Assignees
No one assigned
Labels
C-extension installation testing
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jhunkeler @pllim