Fix compound model fit failure #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 63.42% 62.67% -0.75%
==========================================
Files 47 47
Lines 2614 2650 +36
==========================================
+ Hits 1658 1661 +3
- Misses 956 989 +33
Continue to review full report at Codecov.
|
|
This needs a little more work before review, a case I didn't initially test is failing at the moment. EDIT: now ready for review! |
8544c3d to
8160233
Compare
javerbukh
reviewed
Sep 9, 2020
javerbukh
approved these changes
Sep 9, 2020
9e90433 to
79c0be2
Compare
PatrickOgle
approved these changes
Sep 10, 2020
|
@PatrickOgle - can you make a github issue about that specifically and link it here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the displayed parameters after fitting a compound model was failing, due to
specutils.QuantityModelnot being subscriptable with the component model names. I left in the old parameter update code to be triggered if the resulting model isn't a QuantityModel (I don't know if this will actually happen ever, but better safe than sorry). Fixes a bug raised in #263 by @PatrickOgle that fell off my radar earlier in the year (TypeError: 'QuantityModel' object is not subscriptable).