Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[split-node] Revert splitting setupDB #6649

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

jellonek
Copy link
Contributor

Turns out that splitting databases require more work and was improperly tested.

Copy link

codecov bot commented Jan 21, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12407 1 12406 5
View the top 1 failed tests by shortest run time
github.com/spacemeshos/go-spacemesh/p2p/pubsub TestGossip
Stack Traces | 10s run time
=== RUN   TestGossip
    pubsub_test.go:43: 
        	Error Trace:	.../p2p/pubsub/pubsub_test.go:43
        	Error:      	Condition never satisfied
        	Test:       	TestGossip
--- FAIL: TestGossip (10.00s)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@jellonek jellonek merged commit 9533d5e into node-split-poc Jan 21, 2025
13 of 14 checks passed
@jellonek jellonek deleted the node-split/revert-setupdb branch January 21, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants