Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Add static helper method #121

Closed
wants to merge 1 commit into from
Closed

Add static helper method #121

wants to merge 1 commit into from

Conversation

F43nd1r
Copy link
Contributor

@F43nd1r F43nd1r commented Nov 9, 2016

The code in the readme is really just boilerplate code, which could be easily extracted in a static helper, as I just did here. I also adjusted the sample to show how it's used.

@spacecowboy
Copy link
Owner

I like it!

Couple of things:

  • will likely conflict with
    Fixed FileUriExposed error on Nougat properly #118 which I'm
    planning on merging any day now.
  • the method should be in AbstractFilePickerActivity because it's general
    functionality
  • some tests would be nice (but I can add those if that's problematic)

@F43nd1r
Copy link
Contributor Author

F43nd1r commented Nov 9, 2016

I haven't looked at the beta yet. I'll definetly wait for the merge and then check back how this can fit with it.
I wasn't sure about the class, as a static method like this could be anywhere, so I just used the only class I already had in my imports.

One question: Are there any resources how to use this library to access files which can only be reached through the SAF?

@spacecowboy
Copy link
Owner

spacecowboy commented Nov 9, 2016 via email

@spacecowboy
Copy link
Owner

@F43nd1r you mean like physical SD cards? That is still an open question. There doesn't seem to be a way to access them outside of SAF.

@spacecowboy
Copy link
Owner

Sorry for the delay @F43nd1r . I just kind of forgot about this PR.

Rebased and moved this functionality in #138

@spacecowboy spacecowboy closed this Apr 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants