refactor!: proof_of_sql_parser::intermediate_ast::PoSQLTimezone
with sqlparser::ast::TimezoneInfo
in the proof-of-sql crate
#451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!
is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh
.Rationale for this change
This PR addresses the need to replace the
proof_of_sql_parser::PoSQLTime
with thesqlparser::ast::TimezoneInfo
in theproof-of-sql
crate as part of a larger transition toward integrating thesqlparser
.This change is a subtask of issue #235, with the main goal of streamlining the repository by switching to the
sqlparser
crate and gradually replacing intermediary constructs likeproof_of_sql_parser::intermediate_ast
withsqlparser::ast
.What changes are included in this PR?
proof_of_sql_parser::PoSQLTimeZone
have been replaced withsqlparser::ast::TimezoneInfo
PoSQLTimeZone
has been updated to maintain the original functionality, ensuring no changes to the logic or behavior.TimeZoneInfo
doesn't supportoffset
and a trait has been added for itAre these changes tested?
Yes
Part of #235
Part of #351
Note for Reviewers
PosqlTimeUnit
has been kept intact due tosqlparser::ast
not having related structures or enums to do so.PosqlTimeStamp
will be refactored inLiteral -> ast::Expr
PR asPosqlTimeStamp
has been integrated withLiteral::TimeStampTZ
, which makes refactor redundant in this PR. I have included a util function for the refactor of TimeStamp