refactor!: proof_of_sql_parser::intermediate_ast::ResourceId with sqlparser::ast::ObjectName in the proof-of-sql crate
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
iajoiner
reviewed
Jan 2, 2025
96bab42 to
f971384
Compare
…sqlparser::ast::ObjectName` in the proof-of-sql crate
1a2d1dd to
a146bd2
Compare
iajoiner
reviewed
Jan 6, 2025
Comment on lines
+12
to
+20
| // /// Error types for `TableRef`. | ||
| // #[derive(Snafu, Debug, PartialEq, Eq)] | ||
| // pub enum TableRefError { | ||
| // #[snafu(display("Missing schema or table identifier in ObjectName"))] | ||
| // MissingSchemaOrTable { | ||
| // /// The problematic `ObjectName`. | ||
| // object_name: ObjectName, | ||
| // }, | ||
| // } |
There was a problem hiding this comment.
Let's remove these please.
iajoiner
reviewed
Jan 6, 2025
| use core::{ | ||
| fmt, | ||
| fmt::{Display, Formatter}, | ||
| str::FromStr, | ||
| }; | ||
| use proof_of_sql_parser::{impl_serde_from_str, ResourceId}; | ||
| use sqlparser::ast::Ident; | ||
| // use snafu::Snafu; |
iajoiner
reviewed
Jan 6, 2025
| #[must_use] | ||
| pub fn new(resource_id: ResourceId) -> Self { | ||
| Self { resource_id } | ||
| pub fn new(object_name: ObjectName) -> Self { |
There was a problem hiding this comment.
Hmm we either do not allow ObjectName with other than one or two Ident for TableRef or we can put two Idents there with schema_name optional. Personally I prefer the latter option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
This PR addresses the need to replace the
proof_of_sql_parser::ResourceIdwith thesqlparser::ast::ObjectNamein theproof-of-sqlcrate as part of a larger transition toward integrating thesqlparser.This change is a subtask of issue #235, with the main goal of streamlining the repository by switching to the
sqlparsercrate and gradually replacing intermediary constructs likeproof_of_sql_parser::intermediate_astwithsqlparser::ast.What changes are included in this PR?
proof_of_sql_parser::ResourceIdhave been replaced withsqlparser::ast::ObjectNameResourceIdhas been updated to maintain the original functionality, ensuring no changes to the logic or behavior.ObjectNamedoesn't supportCopytrait so we have needed few clones in the places where values are movedAre these changes tested?
Yes
Part of #235
Fixes #352